Commits · 7688de67c65dbb0ee70bde3f4e3f0ae301429ffa · Chen Yisong / lxc

22 Nov, 2016 30 commits
- Merge pull request #1256 from brauner/2016-09-06/remove_atoi · 7688de67
  Serge Hallyn authored Nov 21, 2016
```
remove atoi
```
  7688de67
- confile: non-functional change · d47f1b43
  Christian Brauner authored Nov 22, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  d47f1b43
- tools/lxc_console: use lxc_safe_uint() · 31299e70
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  31299e70
- tools/lxc_autostart: use lxc_safe_{int,long}() · 63610340
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  63610340
- tools/lxc_ls: use lxc_safe_uint() · 98de6860
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  98de6860
- tools/lxc_top: use lxc_safe_int() · 45419e74
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  45419e74
- tools/lxc_stop: use lxc_safe_long() · 2a9a36aa
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  2a9a36aa
- tests: add unit tests for lxc_safe_long() · cb9df6d4
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  cb9df6d4
- utils: add lxc_safe_long() · 8c57d930
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  8c57d930
- tools/lxc_stop: use lxc_safe_uint() · 04064098
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  04064098
- tools/lxc_execute: use lxc_safe_uint() · fb111ba0
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  fb111ba0
- conf: use lxc_safe_{u}int() · b7b2fde4
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  b7b2fde4
- start: use lxc_safe_int() · d4cff0d2
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  d4cff0d2
- lxc_monitord: use lxc_safe_int() && use exit() · 7e5af997
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  7e5af997
- utils: use lxc_safe_int() · 2d036cca
  Christian Brauner authored Oct 29, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  2d036cca
- conf/ile: avoid atoi() in config_no_new_privs() · e8ec7c9e
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  e8ec7c9e
- conf/ile: avoid atoi() in config_ephemeral() · 66ffdb1a
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  66ffdb1a
- conf/ile: use lxc_safe_uint() in config_autodev() · ff6cb4ed
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  ff6cb4ed
- conf/ile: avoid atoi in config_lsm_aa_incomplete() · a56e2df9
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  a56e2df9
- conf/ile: use lxc_safe_uint() in config_kmsg() · 91863d36
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  91863d36
- conf/ile: use lxc_safe_uint() in config_tty() · 1c30b4ad
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  1c30b4ad
- conf/ile: use lxc_safe_uint() in config_monitor() · 226dc30e
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  226dc30e
- conf/ile: use lxc_safe_u/int() in config_start() · 3590152f
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  3590152f
- conf/ile: use lxc_safe_uint() in config_pts() · 17919969
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  17919969
- confile: use lxc_safe_u/int in config_init_{u,g}id · d1e5d636
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  d1e5d636
- conf/ile: get ip prefix via lxc_safe_uint() · 1c633398
  Christian Brauner authored Oct 28, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  1c633398
- tests: add unit tests for lxc_safe_int() · aa75cefc
  Christian Brauner authored Sep 07, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  aa75cefc
- utils: add lxc_safe_int() · b5f845e7
  Christian Brauner authored Sep 07, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  b5f845e7
- tests: add unit tests for lxc_safe_uint() · 57c7adc3
  Christian Brauner authored Sep 06, 2016
```
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  57c7adc3
- utils: add lxc_safe_uint() · 6bc2eafe
  Christian Brauner authored Sep 06, 2016
```
This function safely parses an unsigned integer. On success it returns 0 and
stores the unsigned integer in @converted. On error it returns a negative
errno.
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
```
  6bc2eafe
21 Nov, 2016 3 commits

Merge pull request #1309 from brauner/2016-11-21/cgfsng_improve_isolcpus_handling · 995ea941
Serge Hallyn authored Nov 21, 2016
```
cgroup: improve isolcpus handling
```
995ea941

cgroups: handle non-existent isolcpus file · 65d29cbc

authored Nov 21, 2016

If the file "/sys/devices/system/cpu/isolated" doesn't exist, we can't just
simply bail. We still need to check whether we need to copy the parents cpu
settings.
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

65d29cbc

cgroup: improve isolcpus handling · 6f9584d8

authored Nov 21, 2016

- add more logging
- only write to cpuset.cpus if we really have to
- simplify cleanup on error and success
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

6f9584d8

20 Nov, 2016 3 commits

Merge pull request #1308 from brauner/2016-11-20/use_ns_info_struct · b8ca2bc7
Stéphane Graber authored Nov 20, 2016
```
use ns info struct and always attach to user namespace first
```
b8ca2bc7

namespace: always attach to user namespace first · 29ed9c13

authored Nov 20, 2016

Move the user namespace at the first position in the array so that we always
attach to it first when iterating over the struct and using setns() to switch
namespaces. This especially affects lxc_attach(): Suppose you cloned a new user
namespace and mount namespace as an unprivileged user on the host and want to
setns() to the mount namespace. This requires you to attach to the user
namespace first otherwise the kernel will fail this check:

    if (!ns_capable(mnt_ns->user_ns, CAP_SYS_ADMIN) ||
        !ns_capable(current_user_ns(), CAP_SYS_CHROOT) ||
        !ns_capable(current_user_ns(), CAP_SYS_ADMIN))
    	return -EPERM;

in

    linux/fs/namespace.c:mntns_install().
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

29ed9c13

attach: use ns_info[LXC_NS_MAX] struct · 26818618

authored Nov 20, 2016

Using custom structs in attach.c risks getting out of sync with the commonly
used ns_info[LXC_NS_MAX] struct and thus attaching to wrong namespaces. Switch
to using ns_info[LXC_NS_MAX].
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

26818618

19 Nov, 2016 4 commits

Merge pull request #1255 from brauner/2016-10-27/cleanup_netdevs_lxd#2439_lxc#1253 · 88a66d01
Serge Hallyn authored Nov 19, 2016
```
remove veth device from host
```
88a66d01

attach, utils: bugfixes · a052913d

authored Nov 19, 2016

- simply check /proc/self/ns
- improve SYSERROR() report
- use #define to prevent gcc & clang to use a VLA
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

a052913d

start, namespace: move ns_info to namespace.{c,h} · 9662e444

authored Oct 31, 2016

It's much more appropriate there and makes start.{c,h} cleaner and leaner.
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

9662e444

start, error: improve log + non-functional changes · 408da065

authored Oct 29, 2016

Improve log and comments in a bunch of places to make it easier for us on bug
reports.
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>

408da065