Commits · 7df21e5394ea3541aa455dbfb8a896196b3912dd · Chen Yisong / lxc

08 Jan, 2020 3 commits
- cmd: fix shebang · 7df21e53
  vikaig authored Dec 23, 2019
```
Signed-off-by: vikaig <vikaig99@gmail.com>
```
  7df21e53
- travis: enable -fsanitize=undefined · 2e11e38f
  Christian Brauner authored Dec 23, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2e11e38f
- fd: only add valid fd to mainloop · 619670be
  dongxinhua authored Dec 21, 2019
```
Signed-off-by: dongxinhua <dongxinhua@huawei.com>
```
  619670be
18 Dec, 2019 1 commit
- seccomp: support s390 seccomp · c2c87fed
  dongxinhua authored Dec 17, 2019
```
Signed-off-by: dongxinhua <dongxinhua@huawei.com>
```
  c2c87fed
13 Dec, 2019 1 commit

cgroups/cgfsng: do not prematurely close file descriptors · 5d562424

authored Dec 12, 2019

When adding the new improved cgroup setup logic I didn't account for the fact
that we need the hierarchy fds up until chown. Add a dedicated cleanup method
to fix this:

lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )

Closes #3228.
Fixes: 1973b62a ("cgroups/cgfsng: improve cgroup creation and removal")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

5d562424

11 Dec, 2019 4 commits
- cgroups/cgfsng: improve cgroup creation and removal · c8f43137
  Christian Brauner authored Dec 11, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c8f43137
- cgroups/cgfsng: rework cgroup removal · 92adc689
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  92adc689
- cgroups/cgfsng: rework legacy cpuset handling · add8018e
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  add8018e
- cgroupfs/cgfsng: pass cgroup to cg_legacy_handle_cpuset_hierarchy() as const char * · 3fe8773d
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3fe8773d
10 Dec, 2019 2 commits
- cgroups: use explicit unsigned type for bitfield · c95a8c8c
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c95a8c8c
- cgroups: flatten hierarchy · e6543787
  Christian Brauner authored Dec 09, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e6543787
09 Dec, 2019 2 commits
- file_utils: use O_NOCTTY | O_NOFOLLOW · afb9722c
  Christian Brauner authored Dec 09, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  afb9722c
- cgroups/devices: enable devpath semantics for cgroup2 device controller · 1d409427
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1d409427
08 Dec, 2019 27 commits
- cgroups/cgfsng: replace lxc_write_file() · 1b7b7923
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1b7b7923
- cgroups/cgfsng: cgfsng_devices_activate() · b805280e
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b805280e
- cgroups/cgfsng: rework cgfsng_nrtasks() · b46a3ae8
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b46a3ae8
- cgroups/cgfsng: rework cgfsng_mount() · 362bcc43
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  362bcc43
- cgroups/cgfsng: rework cgfsng_chown() · 48ee0f07
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  48ee0f07
- cgroups/cgfsng: rework cgfsng_attach() · 78bda28d
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  78bda28d
- cgroups/cgfsng: rework cgfsng_setup_limits() · ae072728
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ae072728
- cgroups/cgfsng: rework cgfsng_setup_limits_legacy() · 6782b4b2
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6782b4b2
- cgroups/cgfsng: rework cgfsng_{get,set}() · b4113388
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b4113388
- cgroups/cgfsng: rework cgfsng_unfreeze() · e650b99a
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e650b99a
- cgroups/cgfsng: rework cgfsng_get_hierarchies() · 1d0ef851
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1d0ef851
- cgroups/cgfsng: rework cgfsng_num_hierarchies() · 9a8bead2
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9a8bead2
- cgroups/cgfsng: rework cgfsng_escape() · f7cdc98a
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f7cdc98a
- cgroups/cgfsng: rework cgfsng_payload_enter() · 68990f1e
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  68990f1e
- cgroups/cgfsng: rework cgfsng_payload_create() · 58222337
  Christian Brauner authored Dec 08, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  58222337
- tree-wide: s/__unused/__lxc_unused/g · f29b71ce
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f29b71ce
- cgroups/cgfsng: rework cgroup attach · 1a4b9d44
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1a4b9d44
- cgroups/cgfsng: don't dereference NULL-pointer · 75bb976e
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  75bb976e
- cgroups/cgfsng: log chown_cgroup_wrapper() · b64652d4
  Christian Brauner authored Dec 07, 2019
```
It's becoming more important on cgroup2 to properly delegate cgroups.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b64652d4
- cgroups/cgfsng: rework cgroup2 unprivileged delegation · 584d340b
  Christian Brauner authored Dec 07, 2019
```
We accidently checked files to delegate for privileged container and not for
unprivileged containers in the pure unified case. Fix that and clean up the
delegation file parsing.

Closes #3206.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  584d340b
- cgroups/cgfsng: rework cgfsng_{monitor,payload}_delegate_controllers() · 43a42cc1
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  43a42cc1
- cgroups/cgfsng: rework cgfsng_monitor_enter() · 50a48614
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  50a48614
- cgroups/cgfsng: rework cgfsng_monitor_create() · 9322b1a3
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9322b1a3
- cgroups/cgfsng: rework cgfsng_monitor_destroy() · e0c8dc5e
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e0c8dc5e
- cgroups/cgfsng: rework cgfsng_payload_destroy() · 1359d223
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1359d223
- log: remove unused compiler attribute · 5fd45ff5
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5fd45ff5
- start: replace compiler attributes · 97c09b99
  Christian Brauner authored Dec 07, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  97c09b99