Commits · 858f62255d92a8dbed020d36aed7e684a0407fce · Chen Yisong / lxc · GitLab

16 Feb, 2021 15 commits
- Merge pull request #3675 from brauner/2021-02-16/fixes · 858f6225
  Stéphane Graber authored Feb 16, 2021
```
cgroups: second batch of cgroup fixes
```
  858f6225
- cgroups: rework how hierarchies are added · 060e54d6
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  060e54d6
- cgroups: fix fd leaks · c426abea
  Christian Brauner authored Feb 16, 2021
```
They didn't really matter because we want to keep them around for as long as
the container lives anyway.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c426abea
- cgroups: allow "" base cgroup paths · f5b04945
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f5b04945
- string_utils: handle empty strings in must_make_path() · 19281251
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  19281251
- cgroups: improve logging · 088db01b
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  088db01b
- cgroups: rework legacy cpuset handling · 033267c9
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  033267c9
- cgroups: fd-based only cgroup creation · da42ac7b
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  da42ac7b
- cgroups: stash fds for the controller mountpoint and base cgroup path · 3486d993
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3486d993
- cgroups: fail when no cgroup hierarchies are found · 5c7b8143
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5c7b8143
- cgroups: rework base cgroup parsing · 600a0163
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  600a0163
- cgroups: rework add_hierarchy() · c72e7cb5
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c72e7cb5
- cgroups: better document stashed file descriptors · 008ccca9
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  008ccca9
- cgroups: stash host's cgroupfs file descriptor · d4cff352
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d4cff352
- cgroups: s/cg_init()/__cgroup_init()/g · 7414bc72
  Christian Brauner authored Feb 16, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7414bc72
15 Feb, 2021 23 commits
- Merge pull request #3674 from brauner/2021-02-15/nesting · 136b349c
  Stéphane Graber authored Feb 15, 2021
```
cgroups: tighten cgroup config items
```
  136b349c
- confile: forbid absolute paths in config items that modify the cgroup layout · f63ef155
  Christian Brauner authored Feb 15, 2021
```
This is not a safety measure but merely is supposed to raise awareness that
these paths are always relative to the cgroup root as determined by
lxc.cgroup.relative.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f63ef155
- confile: forbid walking upwards for confile items that modify cgroup layout · 0a48ee66
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0a48ee66
- confile_utils: normalize paths in config items · 7d714159
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7d714159
- confile: use set_config_path_item() for most cgroup layout modifiers · ee94a8b5
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ee94a8b5
- Merge pull request #3673 from brauner/2021-02-15/nesting · 7e925736
  Stéphane Graber authored Feb 15, 2021
```
cgroups: first batch of cgroup mounting fixes
```
  7e925736
- cgroupfs: rework cgroup2 mounting · a3e5ec26
  Christian Brauner authored Feb 15, 2021
```
We now explicitly refuse to mount cgroups on pure unified layouts when the
container is not running in a separate cgroup namespace. This is not a
regression since we simply always failed before anyway. I will likely fix this
very soon though. But there are bigger fish to fry currently.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a3e5ec26
- cgroups: log early return · 3a86fb37
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3a86fb37
- cgroups: s/__cg_mount_direct()/__cgroupfs_mount()/g · 44234ae1
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  44234ae1
- cgroups: strip LXC_AUTO_CGROUP_MIXED and LXC_AUTO_CGROUP_FULL_MIXED when cgroup… · 6768700d
  Christian Brauner authored Feb 15, 2021
```
cgroups: strip LXC_AUTO_CGROUP_MIXED and LXC_AUTO_CGROUP_FULL_MIXED when cgroup namespaces are supported and used
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6768700d
- cgroups: fix flag checking in legacy mount paths · 80262447
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  80262447
- cgroups: s/cg_mount_cgroup_full()/cgroupfs_bind_mount()/g · 14111650
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  14111650
- cgroups: s/cg_mount_in_cgroup_namespace()/cgroupfs_mount()/g · 074af890
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  074af890
- conf: remove wrong comment · 6cc501f3
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6cc501f3
- cgroups: switch to flag-based checking · c581c8a3
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c581c8a3
- cgroups: don't strip LXC_AUTO_CGROUP_FORCE · 68599aab
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  68599aab
- cgroups: make clear that a flag argument is passed to cgroup mount functions · cdd3b77d
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cdd3b77d
- utils: add development helper to quickly dump a directories contents · 8cdbef77
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8cdbef77
- cgroups: improve cgroup mounting · e7e45fdf
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e7e45fdf
- cgroups: verify that we are actually running in cgroup namespace · 937a3af9
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  937a3af9
- cgroups: pass handler to cgroup mount() method · ab8cd5d9
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ab8cd5d9
- conf: don't pass conf separately to lxc_mount_auto_mounts() · 6d25a524
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6d25a524
- cgroups: move cgns_supported() to cgroup utilities · c988c8b1
  Christian Brauner authored Feb 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c988c8b1
14 Feb, 2021 2 commits
- Merge pull request #3672 from brauner/2021-02-14/fixes · 4b946797
  Stéphane Graber authored Feb 14, 2021
```
start: small fixes
```
  4b946797
- start: fix comment about time namespace preservation · 245066af
  Christian Brauner authored Feb 14, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  245066af