Skip to content

L
lxc
Switch branch/tag
  1. 16 Jan, 2015 4 commits
  3. 15 Jan, 2015 3 commits
    • close-all-fds: fix behavior · d2cf4c37
      Serge Hallyn authored 
      We want to close all inherited fds in three cases - one, if a container
is daemonized.  Two, if the user specifies -C on the lxc-start command
line.  Three, in src/lxc/monitor.c.  The presence of -C is passed in the
lxc_conf may not always exist.

One call to lxc_check_inherited was being done from lxc_start(), which
doesn't know whether we are daemonized.  Move that call to its caller,
lxcapi_start(), which does know.

Pass an explicit closeall boolean as second argument to lxc_check_inherited.
If it is true, then all fds are closed.  If it is false, then we check
the lxc_conf->close_all_fds.

With this, all tests pass, and the logic appears correct.

Note that when -C is not true, then we only warn about inherited fds,
but we do not abort the container start.  This appears to have ben the case
since commit 92c7f629 in 2011.  Unfortunately the referenced URL with
the justification is no longer valid.  We may want to consider becoming
stricter about this again.  (Note that the commit did say "for now")
Signed-off-by: 's avatarSerge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: 's avatarStéphane Graber <stgraber@ubuntu.com>
    • lxc-start-ephemeral: handle the overlayfs workdir option (v2) · 4799a1e7
      Serge Hallyn authored 
      We fixed this some time ago for basic lxc-start, but never did
lxc-start-ephemeral.

Since the lxc-start patches were pushed, Miklos has given us a
way to detect whether we need the workdir= option.  So the
bdev.c code could be simplified to check for "overlay\n" in
/proc/filesystems just as lxc-start-ephemeral does.  This
patch doesn't do that.

Changelog (v2):
	1. use 'overlay' fstype for new overlay upstream module
	2. avoid using unneeded readlines().
Signed-off-by: 's avatarSerge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: 's avatarStéphane Graber <stgraber@ubuntu.com>
    • doc: clarify the description of the veth network type in the manpage. · 38005c54
      Michael Adam authored 
      Signed-off-by: 's avatarMichael Adam <obnox@samba.org>
Acked-by: 's avatarStéphane Graber <stgraber@ubuntu.com>
  5. 13 Jan, 2015 3 commits
  7. 12 Jan, 2015 2 commits
  9. 10 Jan, 2015 16 commits
  11. 08 Jan, 2015 2 commits
  13. 05 Jan, 2015 5 commits
  15. 19 Dec, 2014 4 commits
  17. 04 Dec, 2014 1 commit