Commits · 8bf64b77ac8a6f7d447709cdb6c6ad768f2302c1 · Chen Yisong / lxc

10 Jan, 2020 1 commit

network: rework network device creation · 8bf64b77

authored Jan 10, 2020

This makes all the codepaths easier to follow and also moves and renames
devices in one single step.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

8bf64b77

09 Jan, 2020 8 commits

network: fix network device removal · 0104c121

authored Jan 09, 2020

We can't delete by netdev->ifindex since that's the ifindex of the device in
the container, not on the host. The correct thing is done below.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

0104c121

tests: log api reboot test failures · 3919322d
Christian Brauner authored Jan 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
3919322d
network: fix typ and formatting in comment · 0858c829
Christian Brauner authored Jan 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
0858c829

network: improve veth device creation · 54256301

authored Jan 09, 2020

This allows us to avoid having to move the network device. It also allows us to
work around a kernel bug that in combination with a recent change in systemd
244 causes uses of systemd-networkd to not get an ip address.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

54256301

Merge pull request #3249 from brauner/2020-01-09/bugfixes · 90ddf3c0
Stéphane Graber authored Jan 09, 2020
```
handle kernel version <--> header incompatibility
```
90ddf3c0

start: handle kernel header and kernel incompatability · c718fac1

authored Jan 09, 2020

We might e.g. be compiled in a container with old kernel headers. In this
scenario CLONE_PIDFD will work but pidfd_send_signal() might not be detected
because __NR_pidfd_send_signal is not defined because the kernel headers don't
match the kernel version.

This explains and fixes test-suite hangs on Jenkins I've recently debugged.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

c718fac1

tests: timeout after 60 seconds · 38bbeb79

authored Jan 09, 2020

That should be more than enough to reboot.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

38bbeb79

mainloop: add missing \n · 1126d148
Christian Brauner authored Jan 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
1126d148

08 Jan, 2020 1 commit
- Merge pull request #3241 from brauner/2019-12-25/remove_procfs_pidfd_support · f036cc8a
  Serge Hallyn authored Jan 08, 2020
```
start: remove procfs pidfd support
```
  f036cc8a
04 Jan, 2020 1 commit
- Merge pull request #3247 from Rachid-Koucha/patch-1 · 26eb73ca
  Stéphane Graber authored Jan 04, 2020
```
Suppress useless udhcpc directory
```
  26eb73ca
03 Jan, 2020 1 commit

Suppress useless udhcpc directory · eeea2ef1

authored Jan 03, 2020

The udhcpc directory is created with "mkdir -p" at the place dynamically specified by "busybox udhcpc --help".
Signed-off-by: Rachid Koucha <rachid.koucha@gmail.com>

eeea2ef1

27 Dec, 2019 3 commits

Merge pull request #3244 from Rachid-Koucha/master · 2b0d4847
Christian Brauner authored Dec 27, 2019
```
Adaptation to latest busybox
```
2b0d4847
Merge pull request #3243 from Rachid-Koucha/patch-1 · d55ea1ec
Christian Brauner authored Dec 27, 2019
```
Word repetition in comment
```
d55ea1ec

Adaptation to latest busybox · e76e315c

authored Dec 27, 2019

In busybox 1.30, the help of udhcpc for "-s" option changed:
--> busybox v1.27.2: -s,--script PROG	Run PROG at DHCP events (default /usr/share/udhcpc/default.script)
--> busybox v1.30.1: -s PROG		Run PROG at DHCP events (default /etc/udhcpc/default.script)
So, I changed the command line which extracts the script name to make it work for both versions
Signed-off-by: Rachid Koucha <rachid.koucha@gmail.com>

e76e315c

26 Dec, 2019 2 commits

start: remove procfs pidfd support · b94283e1

authored Dec 25, 2019

We'll only rely on proper anon-inode based pidfd support in the future.
There's no good reason to use the procfs fallback. All the fancy features we
might want to use are only available with anon-inode pidfds.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

b94283e1

Word repetition in comment · f073d460

authored Dec 26, 2019

create_run_template(): Double "will mount" in a comment
Signed-off-by: Rachid Koucha <rachid.koucha@gmail.com>

f073d460

25 Dec, 2019 1 commit
- Merge pull request #3238 from brauner/2019-12-23/travis · 33db34ef
  Stéphane Graber authored Dec 25, 2019
```
travis: enable -fsanitize=undefined
```
  33db34ef
23 Dec, 2019 5 commits
- Merge pull request #3239 from vikaig/fix-shebang · 2d50f340
  Christian Brauner authored Dec 23, 2019
```
cmd: fix shebang
```
  2d50f340
- cmd: fix shebang · aac4e12a
  vikaig authored Dec 23, 2019
```
Signed-off-by: vikaig <vikaig99@gmail.com>
```
  aac4e12a
- travis: enable -fsanitize=undefined · 384db5d7
  Christian Brauner authored Dec 23, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  384db5d7
- Merge pull request #3235 from xinhua9569/master · b4fde4ec
  Christian Brauner authored Dec 23, 2019
```
fd: only add valid fd to mainloop
```
  b4fde4ec
- fd: only add valid fd to mainloop · 4879faff
  dongxinhua authored Dec 21, 2019
```
Signed-off-by: dongxinhua <dongxinhua@huawei.com>
```
  4879faff
17 Dec, 2019 3 commits
- Merge pull request #3233 from xinhua9569/master · c7ba8828
  Christian Brauner authored Dec 17, 2019
```
seccomp: support s390 seccomp
```
  c7ba8828
- Merge pull request #3232 from brauner/2019-12-17/cgroup2_api_extension · cbeb79dd
  Stéphane Graber authored Dec 16, 2019
```
api_extensions: advertise cgroup2 support
```
  cbeb79dd
- seccomp: support s390 seccomp · 3c3fab00
  dongxinhua authored Dec 17, 2019
```
Signed-off-by: dongxinhua <dongxinhua@huawei.com>
```
  3c3fab00
16 Dec, 2019 1 commit
- api_extensions: advertise cgroup2 support · ad92bbcd
  Christian Brauner authored Dec 17, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ad92bbcd
12 Dec, 2019 2 commits

Merge pull request #3229 from brauner/2019-12-12/cgroup_legacy_layout_regression · 56cf2a57
Stéphane Graber authored Dec 12, 2019
```
cgroups/cgfsng: do not prematurely close file descriptors
```
56cf2a57

cgroups/cgfsng: do not prematurely close file descriptors · 78eb6aa6

authored Dec 12, 2019

When adding the new improved cgroup setup logic I didn't account for the fact
that we need the hierarchy fds up until chown. Add a dedicated cleanup method
to fix this:

lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, , 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, tasks, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc b1 20191212205052.712 WARN cgfsng - cgroups/cgfsng.c:fchowmodat:1481 - Bad file descriptor - Failed to fchownat(-9, cgroup.procs, 1000000000, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )

Closes #3228.
Fixes: 1973b62a ("cgroups/cgfsng: improve cgroup creation and removal")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

78eb6aa6

11 Dec, 2019 3 commits
- Merge pull request #3226 from brauner/cgroup_removal · 28a41fc2
  Stéphane Graber authored Dec 11, 2019
```
cgroupfs: improve cgroup removal
```
  28a41fc2
- cgroups/cgfsng: improve cgroup creation and removal · 1973b62a
  Christian Brauner authored Dec 11, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1973b62a
- Merge pull request #3225 from brauner/cgroup_improvements · d0986340
  Stéphane Graber authored Dec 10, 2019
```
cgroups/cgfsng: rework legacy cpuset handling
```
  d0986340
10 Dec, 2019 6 commits
- cgroups/cgfsng: rework cgroup removal · 8e64b673
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8e64b673
- cgroups/cgfsng: rework legacy cpuset handling · c5b8049e
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c5b8049e
- cgroupfs/cgfsng: pass cgroup to cg_legacy_handle_cpuset_hierarchy() as const char * · f990d3bf
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f990d3bf
- Merge pull request #3223 from brauner/flatten_cgroup_hierarchy · dc3cdf28
  Stéphane Graber authored Dec 10, 2019
```
cgroups: flatten hierarchy
```
  dc3cdf28
- cgroups: use explicit unsigned type for bitfield · aaa1ec28
  Christian Brauner authored Dec 10, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  aaa1ec28
- cgroups: flatten hierarchy · fe70edee
  Christian Brauner authored Dec 09, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  fe70edee
09 Dec, 2019 2 commits
- Merge pull request #3222 from brauner/security · e340fefe
  Stéphane Graber authored Dec 09, 2019
```
file_utils: use O_NOCTTY | O_NOFOLLOW
```
  e340fefe
- file_utils: use O_NOCTTY | O_NOFOLLOW · ef6d231f
  Christian Brauner authored Dec 09, 2019
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ef6d231f