Skip to content

L
lxc
Switch branch/tag
  1. 28 May, 2010 2 commits
  3. 27 May, 2010 7 commits
  5. 26 May, 2010 10 commits
  7. 24 May, 2010 1 commit
  9. 19 May, 2010 4 commits
  11. 18 May, 2010 2 commits
  13. 12 May, 2010 7 commits
  15. 10 May, 2010 7 commits
    • no need to use a temporary directory for pivoting · 25368b52
      Ferenc Wagner authored 
      Ferenc Wagner <wferi@niif.hu> writes:

> Daniel Lezcano <dlezcano@fr.ibm.com> writes:
>
>> Ferenc Wagner wrote:
>>
>>> Daniel Lezcano <daniel.lezcano@free.fr> writes:
> >>>> Ferenc Wagner wrote:
> >>>>
> >>>>> While playing with lxc-start, I noticed that /tmp is infested by
> >>>>> empty lxc-r* directories: [...] Ok, this name comes from lxc-rootfs
> >>>>> in conf.c:setup_rootfs.  After setup_rootfs_pivot_root returns, the
> >>>>> original /tmp is not available anymore, so rmdir(tmpname) at the
> >>>>> bottom of setup_rootfs can't achieve much.  Why is this temporary
> >>>>> name needed anyway?  Is pivoting impossible without it?
> >>>>
> >>>> That was put in place with chroot, before pivot_root, so the distro's
> >>>> scripts can remount their '/' without failing.
> >>>>
> >>>> Now we have pivot_root, I suppose we can change that to something cleaner...
>>> Like simply nuking it?  Shall I send a patch?
>>
>> Sure, if we can kill it, I will be glad to take your patch :)
>
> I can't see any reason why lxc-start couldn't do without that temporary
> recursive bind mount of the original root.  If neither do you, I'll
> patch it out and see if it still flies.

For my purposes the patch below works fine.  I only run applications,
though, not full systems, so wider testing is definitely needed.

Thanks,
Feri.

>From 98b24c13f809f18ab8969fb4d84defe6f812b25c Mon Sep 17 00:00:00 2001
Date: Thu, 6 May 2010 14:47:39 +0200

That was put in place before lxc-start started using pivot_root, so
the distro scripts can remount / without problems.
Signed-off-by: 's avatarFerenc Wagner <wferi@niif.hu>
Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
    • Make dynamic busybox supported · bf6cc736
      Daniel Lezcano authored 
      Bind mount host library path.
Weird but some distro provide busybox as a dynamically linked binary.
Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
    • make lxc-checkconfig more explicit · 8208b295
      Guillaume Zitta authored 
      With a friend, we installed lxc on his server.
We spend 1 hour on the kernel config because we didn't knew :
- that lxc-checkconfig is a bash script and it can check a config before
running it
- which kernel config item whas not good
- that CONFIG_SECURITY_FILE_CAPABILITIES is obsolete since 2.6.33

So, here is a patch for lxc-checkconfig that could save time for lxc newbies
Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
Modified-by: 's avatarDaniel Lezcano <daniel.lezcano@free.fr>
Signed-off-by: 's avatarGuillaume Zitta <lxc@zitta.fr>
    • add missing /dev/pts directory · 10e657e5
      Daniel Lezcano authored 
      Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
    • update INSTALL file · 2f462f4b
      Daniel Lezcano authored 
      "lxc configure does not exist. You need to run ./autogen.sh to create it.
I think it needs to either be documented in INSTALL or you provide ./configure"
Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
Reported-by: 's avatarJamal Hadi Salim <hadi@cyberus.ca>
    • factor out pivot_root code · 0b7a8353
      Daniel LEzcano authored 
      Clean up and factor a bit the pivot_root code.
Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
    • fix pivot_root temporary directory · 1b09f2c0
      Daniel Lezcano authored 
      First of all, when trying to start a container in a read-only root
lxc-start complains:
  lxc-start: Read-only file system - can't make temporary mountpoint

This is in conf.c:setup_rootfs_pivot_root() function.  That function
uses optional parameter "lxc.pivotdir", or creates (and later removes)
a temporary directory for pivot_root.  Obviously there's no way to
create a directory in a read-only filesystem.

But lxc.pivotdir does not work either. In the function mentioned above
it is used with leading dot (eg. if I specify "lxc.pivotdir=pivot" in
the config file the pivot_root() syscall will be made to ".pivot" with
leading dot, not to "pivot"), but later on it is used without that dot,
and fails:

  lxc-start: No such file or directory - failed to open /pivot/proc/mounts
  lxc-start: No such file or directory - failed to read or parse mount list '/pivot/proc/mounts'
  lxc-start: failed to pivot_root to '/stage/t'

(that's with "lxc.pivotdir = pivot" in the config file).  After symlinking
pivot to .pivot it still fails:

  lxc-start: Device or resource busy - could not unmount old rootfs
  lxc-start: failed to pivot_root to '/stage/t'
Signed-off-by: 's avatarDaniel Lezcano <dlezcano@fr.ibm.com>
Reported-by: 's avatarMichael Tokarev <mjt@tls.msk.ru>