[RFC] add minimal unit testing for liblxc functions

Signed-off-by: Christian Brauner <cbrauner@suse.de>

Signed-off-by: Christian Brauner <cbrauner@suse.de>

tools: use fclose() after fdopen() + add newline

So far we accidently used close() on the original file descriptor. (After
fdopen() the original fd is considered private and should not be used anymore.
The close operations should be performed on the new file handle. We did the
correct thing on error but not on success.) Using close() on the original fd
caused "Text file busy" errors and prevented the cloned tmpfs container from
starting.
Signed-off-by: Christian Brauner <cbrauner@suse.de>

tools: add missing newline in lxc-create output

Signed-off-by: Christian Brauner <cbrauner@suse.de>

bdev: be smarter about btrfs subvolume detection

tools: use correct runtime path for lxc-ls

So far we've simply been using RUNTIME_PATH for the privileged and unprivileged
case. We should actually use XDG_RUNTIME_DIR for the unprivileged case.
Signed-off-by: Christian Brauner <cbrauner@suse.de>

When a container c is on a btrfs filesystem but is directory backed, copying
the container will default to snapshot. This is because of
should_default_to_snapshot() returning true in this case because c is on a
btrfs filesystem. We should make sure that should_default_to_snapshot() only
returns true, when c itself is a btrfs subvolume.
Signed-off-by: Christian Brauner <cbrauner@suse.de>

Update English and Japanese lxc-attach(1)

* Add undocumented options (-v/--set-var, --keep-var, -f/--rcfile)
* Change order of option in SYNOPSIS (-L that is placed after "command")
* Add long options in SYNOPSIS
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

* Add undocumented options (-v/--set-var, --keep-var, -f/--rcfile)
* Change order of option in SYNOPSIS (-L that is placed after "command")
* Add long options in SYNOPSIS
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

log: fix log_append_stderr()

Log output currently looks like this:

	lxc-copy: debbdev/lxcdir.c: dir_clonepaths: 45 directories cannot be snapshotted.  Try aufs or overlayfs.

we rather want it to be:

	lxc-copy: deb: bdev/lxcdir.c: dir_clonepaths: 45 directories cannot be snapshotted.  Try aufs or overlayfs.
Signed-off-by: Christian Brauner <cbrauner@suse.de>

tree-wide: replace readdir_r() with readdir()

Signed-off-by: Christian Brauner <cbrauner@suse.de>

templates: add support for new arch on Alpine Linux

Signed-off-by: Carlo Landmeter <clandmeter@gmail.com>

lxc-attach: add -f option & cleanup

The rest of this block uses spaces instead of tabs already.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

Otherwise a container with a non-standard configuration file
can be started but not attached to.
Fixes the following case:
 # lxc-start -n ct -f /different/path/my.config
 # lxc-attach -n ct
 Error: container ct is not defined
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

doc: Add documentation of lxc.syslog to Korean lxc.container.conf(5)

Update for commit 204dfdf2Signed-off-by: Sungbae Yoo <sungbae.yoo@samsung.com>

partially reorganize repo

doc: Add documentation of lxc.syslog to Japanese lxc.container.conf(5)

and add local6 to valid facility
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

- tools: move lxc commands to common subfolder
- tests: adapt include search path
Signed-off-by: Christian Brauner <cbrauner@suse.de>

Signed-off-by: Christian Brauner <cbrauner@suse.de>

This allows us to avoid using relative includes which is cleaner in the long
run when we create subdirectories for other components of liblxc.
Signed-off-by: Christian Brauner <cbrauner@suse.de>

Add syslog support

Signed-off-by: Baptiste Daroussin <bapt@gandi.net>

To activate it specify lxc.syslog = <afacility>
For now the available facilities are: daemon, local[0-7] others will be
rejected

syslog got only activated after the function that checks for inheritance
of fd is passed in order to make sure the syslog fd is not inherited
and prevent the creation of the fd is any log have been issued during
the checks (which would end up in an infinite loop)
Signed-off-by: Fatih ACAR <fatih.acar@gandi.net>
Signed-off-by: Ahmed Amamou <ahmed@gandi.net>
Signed-off-by: Baptiste Daroussin <bapt@gandi.net>
Signed-off-by: William Dauchy <william@gandi.net>

criu: replace tmpnam() with mkstemp()

Signed-off-by: Christian Brauner <cbrauner@suse.de>

conf: set pty_info to NULL after free

This fixes a double free corruption on container-requested
reboots when lxc_spawn() fails before receiving the ttys, as
lxc_fini() (part of __lxc_start()'s cleanup) calls
lxc_delete_tty().
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

attach: use setns instead of unshare

Revert "Merge pull request #1103 from brauner/2016-07-27/fix_android_…