Commits · a1093fdeda8ffddb41a9cedfcd04c295fefeeb2e · Chen Yisong / lxc

12 Apr, 2021 9 commits
- ci: build with -Wall -Werror · a1093fde
  Evgeny Vereshchagin authored Apr 12, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  a1093fde
- ci: turn on strict_string_checks · 2a5b9cd6
  Evgeny Vereshchagin authored Apr 12, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  2a5b9cd6
- ci: get around https://github.com/lxc/lxc/issues/3796 · 44818e89
  Evgeny Vereshchagin authored Apr 12, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  44818e89
- ci: prevent lxc-exercise from running indefinitely · 935dc9a0
  Evgeny Vereshchagin authored Apr 12, 2021
```
and show all the commands it runs to make it easier to
debug potential issues.
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  935dc9a0
- ci: get around https://github.com/lxc/lxc/issues/3788 · 335a1405
  Evgeny Vereshchagin authored Apr 12, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  335a1405
- ci: get around https://github.com/lxc/lxc/issues/3798 · 02c7e7af
  Evgeny Vereshchagin authored Apr 12, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  02c7e7af
- ci: switch to lxc-exercise from the lxc-ci repository · 8f1500a9
  Evgeny Vereshchagin authored Apr 12, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  8f1500a9
- ci: link lib[au]san with init.lxc.static statically · 7b8b8357
  Evgeny Vereshchagin authored Apr 12, 2021
```
init.lxc.static is run in arbitrary containers where the libasan library lxc has been built with
isn't always installed. To make it work let's override GCC's default and link both libasan
and libubsan statically. It should help to fix issues like
```
  ++ lxc-execute -n c1 -- sudo -u ubuntu /nnptest
  lxc-init: error while loading shared libraries: libasan.so.5: cannot open shared object file: No such file or directory
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  7b8b8357
- ci: an attempt to run the tests under ASan/UBsan · 5a0720a9
  Evgeny Vereshchagin authored Apr 11, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  5a0720a9
18 Apr, 2021 1 commit
- Merge pull request #3799 from evverx/apparmor-bytes · dc117b6b
  Christian Brauner authored Apr 18, 2021
```
apparmor: turn bytes into null-terminated strings before calling strcspn
```
  dc117b6b
17 Apr, 2021 6 commits
- Merge pull request #3790 from brauner/2021-04-15.fixes · 44990884
  Stéphane Graber authored Apr 17, 2021
```
lxc_clone & configure fix
```
  44990884
- commands: don't needlessly allocate · 3698c491
  Christian Brauner authored Apr 17, 2021
```
Fixes: #3796
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3698c491
- Merge pull request #3797 from evverx/pass-on-asan · 95dfbd42
  Christian Brauner authored Apr 17, 2021
```
tests: pass on ASAN/UBSAN options to several tests
```
  95dfbd42
- process_utils: free stack after return · 431c1c05
  Christian Brauner authored Apr 15, 2021
```
Fixes: #3789
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  431c1c05
- configure: fix sanitizer compilation · cdfa8f13
  Christian Brauner authored Apr 15, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cdfa8f13
- error_utils: add missing macro.h include · 6f527abc
  Christian Brauner authored Apr 17, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6f527abc
16 Apr, 2021 1 commit
- Merge pull request #3794 from evverx/gh3791 · 00f224bb
  Christian Brauner authored Apr 16, 2021
```
tests: stop cutting off right square brackets in share_ns
```
  00f224bb
15 Apr, 2021 1 commit
- Merge pull request #3793 from evverx/busybox-test · d5ec7f1e
  Christian Brauner authored Apr 16, 2021
```
tests: switch to the "busybox" template in lxc-test-checkpoint-restore
```
  d5ec7f1e
14 Apr, 2021 3 commits
- Merge pull request #3785 from brauner/2021-04-14.fixes · fdc56afe
  Stéphane Graber authored Apr 14, 2021
```
lxccontainer: fix container creation error paths
```
  fdc56afe
- Merge pull request #3784 from evverx/attach-memleak · ff3f956a
  Christian Brauner authored Apr 14, 2021
```
tests: fix a memory leak in attach
```
  ff3f956a
- lxccontainer: fix container creation error paths · 190f83db
  Christian Brauner authored Apr 14, 2021
```
Fixes: #3782
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  190f83db
13 Apr, 2021 3 commits
- Merge pull request #3783 from evverx/cgpath-memleak2 · c4142ec2
  Christian Brauner authored Apr 13, 2021
```
tests: fix a memory leak in cgpath
```
  c4142ec2
- Merge pull request #3781 from evverx/lxcpath-memleak · ca52b7ff
  Christian Brauner authored Apr 13, 2021
```
tests: fix a memory leak in lxcpath
```
  ca52b7ff
- Merge pull request #3780 from evverx/cgpath-mem-leak · 274615f9
  Christian Brauner authored Apr 13, 2021
```
tests: fix a memory leak in cgpath
```
  274615f9
12 Apr, 2021 8 commits

apparmor: turn bytes into null-terminated strings before calling strcspn · 699e7f88

authored Apr 12, 2021

```
==70349==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000009fb at pc 0x000000433b70 bp 0x7ffcde087810 sp 0x7ffcde086fd0
READ of size 12 at 0x6020000009fb thread T0
    #0 0x433b6f in strcspn (/usr/bin/lxc-execute+0x433b6f)
    #1 0x7f720413a5cb in apparmor_process_label_get /home/runner/work/lxc/lxc/src/lxc/lsm/apparmor.c:449:8
    #2 0x7f720413bc2a in apparmor_prepare /home/runner/work/lxc/lxc/src/lxc/lsm/apparmor.c:1104:13
    #3 0x7f720409b6e9 in lxc_init /home/runner/work/lxc/lxc/src/lxc/start.c:848:8
    #4 0x7f72040a395a in __lxc_start /home/runner/work/lxc/lxc/src/lxc/start.c:2009:8
    #5 0x7f7203fc7186 in lxc_execute /home/runner/work/lxc/lxc/src/lxc/execute.c:99:9
    #6 0x7f7204000e44 in do_lxcapi_start /home/runner/work/lxc/lxc/src/lxc/lxccontainer.c:1112:9
    #7 0x7f7203ff0c07 in lxcapi_start /home/runner/work/lxc/lxc/src/lxc/lxccontainer.c:1149:8
    #8 0x4c6912 in main /home/runner/work/lxc/lxc/src/lxc/tools/lxc_execute.c:224:9
    #9 0x7f72034ac0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    #10 0x41d93d in _start (/usr/bin/lxc-execute+0x41d93d)
+ echo ---

0x6020000009fb is located 0 bytes to the right of 11-byte region [0x6020000009f0,0x6020000009fb)
allocated by thread T0 here:
    #0 0x496399 in realloc (/usr/bin/lxc-execute+0x496399)
    #1 0x7f7203fcf85c in fd_to_buf /home/runner/work/lxc/lxc/src/lxc/file_utils.c:463:10
    #2 0x7f720413a52b in apparmor_process_label_get /home/runner/work/lxc/lxc/src/lxc/lsm/apparmor.c:442:8
    #3 0x7f720413bc2a in apparmor_prepare /home/runner/work/lxc/lxc/src/lxc/lsm/apparmor.c:1104:13
    #4 0x7f720409b6e9 in lxc_init /home/runner/work/lxc/lxc/src/lxc/start.c:848:8
    #5 0x7f72040a395a in __lxc_start /home/runner/work/lxc/lxc/src/lxc/start.c:2009:8
    #6 0x7f7203fc7186 in lxc_execute /home/runner/work/lxc/lxc/src/lxc/execute.c:99:9
    #7 0x7f7204000e44 in do_lxcapi_start /home/runner/work/lxc/lxc/src/lxc/lxccontainer.c:1112:9
    #8 0x7f7203ff0c07 in lxcapi_start /home/runner/work/lxc/lxc/src/lxc/lxccontainer.c:1149:8
    #9 0x4c6912 in main /home/runner/work/lxc/lxc/src/lxc/tools/lxc_execute.c:224:9
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

699e7f88

Merge pull request #3779 from brauner/2021-04-12/attach_fixes · aeff7df6
Stéphane Graber authored Apr 12, 2021
```
attach: fixes
```
aeff7df6

Revert "rexec: mark all fds as close-on-exec if possible" · 09a83db5

authored Apr 12, 2021

This reverts commit 531d36ad.

Callers might want to explicilty inhert file descriptors so we can't
close them behind their back when we exec.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

09a83db5

attach: don't return early when calculating namespaces via pidfd · 0b8e876f
Christian Brauner authored Apr 12, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
0b8e876f
Merge pull request #3778 from brauner/2021-04-12/fixes · d32dcd01
Stéphane Graber authored Apr 12, 2021
```
conf: idmaptool fixes
```
d32dcd01
conf: don't report success when idmaptools lack all privilege · a864a2e1
Christian Brauner authored Apr 12, 2021
```
Fixes: #3777
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a864a2e1
conf: simplify idmaptool_on_path_and_privileged() · 83cb7362
Christian Brauner authored Apr 12, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
83cb7362
tests: pass on ASAN/UBSAN options to several tests · 5f850cf9
Evgeny Vereshchagin authored Apr 12, 2021
```
to make it easier to run them under ASan/UBSan.
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
5f850cf9

11 Apr, 2021 2 commits

tests: stop cutting off right square brackets in share_ns · 11ead2c4
Evgeny Vereshchagin authored Apr 11, 2021
```
Closes https://github.com/lxc/lxc/issues/3791Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
11ead2c4

tests: switch to the "busybox" template in lxc-test-checkpoint-restore · 73dc93db

authored Apr 11, 2021

criu can't seem to dump systemd-logind used in Ubuntu due to what appears to be
https://github.com/checkpoint-restore/criu/issues/1430.
Let's switch to busybox where all the processes hopefully can be dumped.

Closes https://github.com/lxc/lxc/issues/3792Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

73dc93db

10 Apr, 2021 4 commits

tests: fix a memory leak in attach · 621c7cc7
Evgeny Vereshchagin authored Apr 10, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
621c7cc7

tests: fix a memory leak in cgpath · f80950ee

authored Apr 10, 2021

```
==131188==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 568 byte(s) in 1 object(s) allocated from:
    #0 0x7f8918943bc8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dbc8)
    #1 0x7f89181ee5a3 in lxc_container_new /home/vagrant/lxc/src/lxc/lxccontainer.c:5264
    #2 0x55ffc5022869 in test_container /home/vagrant/lxc/src/tests/cgpath.c:176
    #3 0x55ffc5023023 in main /home/vagrant/lxc/src/tests/cgpath.c:233
    #4 0x7f891709e0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

f80950ee

tests: fix a memory leak in lxcpath · 4cd72b69

authored Apr 10, 2021

```
$ sudo ./src/tests/lxc-test-lxcpath

=================================================================
==95911==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 39 byte(s) in 1 object(s) allocated from:
    #0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
    #1 0x7effaf5a2de6 in lxcapi_config_file_name /home/vagrant/lxc/src/lxc/lxccontainer.c:3190
    #2 0x562961680c30 in main /home/vagrant/lxc/src/tests/lxcpath.c:49
    #3 0x7effae5150b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
    #0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
    #1 0x7effaf5a2de6 in lxcapi_config_file_name /home/vagrant/lxc/src/lxc/lxccontainer.c:3190
    #2 0x56296168115e in main /home/vagrant/lxc/src/tests/lxcpath.c:77
    #3 0x7effae5150b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 21 byte(s) in 1 object(s) allocated from:
    #0 0x7effafc8d3dd in strdup (/lib/x86_64-linux-gnu/libasan.so.5+0x963dd)
    #1 0x7effaf5a2de6 in lxcapi_config_file_name /home/vagrant/lxc/src/lxc/lxccontainer.c:3190
    #2 0x562961680f0a in main /home/vagrant/lxc/src/tests/lxcpath.c:63
    #3 0x7effae5150b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

SUMMARY: AddressSanitizer: 81 byte(s) leaked in 3 allocation(s).
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

4cd72b69

tests: fix a memory leak in cgpath · 5a9fae9e

authored Apr 10, 2021

```
$ sudo ./src/tests/lxc-test-cgpath
Container creation tests...Passed
Container creation with LXCPATH tests...Passed

=================================================================
==57206==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 296 byte(s) in 1 object(s) allocated from:
    #0 0x7fef22c27dc6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10ddc6)
    #1 0x557c6e3ce3d9 in cgroup_ops_init cgroups/cgfsng.c:3347
    #2 0x557c6e3d6516 in cgroup_init cgroups/cgroup.c:33
    #3 0x557c6e3788e2 in test_running_container /home/vagrant/lxc/src/tests/cgpath.c:102
    #4 0x557c6e379c69 in test_container /home/vagrant/lxc/src/tests/cgpath.c:197
    #5 0x557c6e379e37 in main /home/vagrant/lxc/src/tests/cgpath.c:233
    #6 0x7fef2136c0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Direct leak of 296 byte(s) in 1 object(s) allocated from:
    #0 0x7fef22c27dc6 in calloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10ddc6)
    #1 0x557c6e3ce3d9 in cgroup_ops_init cgroups/cgfsng.c:3347
    #2 0x557c6e3d6516 in cgroup_init cgroups/cgroup.c:33
    #3 0x557c6e3788e2 in test_running_container /home/vagrant/lxc/src/tests/cgpath.c:102
    #4 0x557c6e379c69 in test_container /home/vagrant/lxc/src/tests/cgpath.c:197
    #5 0x557c6e379e61 in main /home/vagrant/lxc/src/tests/cgpath.c:237
    #6 0x7fef2136c0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

5a9fae9e

07 Apr, 2021 2 commits
- Merge pull request #3775 from brauner/2021-04-07/fixes · 965502a0
  Stéphane Graber authored Apr 07, 2021
```
confile: make lxc_get_config() and lxc_get_config_net() always return…
```
  965502a0
- confile: make lxc_get_config() and lxc_get_config_net() always return non-NULL · 6773e108
  Christian Brauner authored Apr 07, 2021
```
Introduce the concept of an unsupported config item.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6773e108