OCI image spec dosen't specify action when there is
no /etc/passwd or /etc/group. So if there is no
/etc/passwd with string user info, set uid to 0. If there
is no /etc/group with string group info, set gid to 0.

Signed-off-by: Jungsub Shin jungsub_shin@tmax.co.kr

oci template changes character user info to uid, gid
according to OCI image spec.

Signed-off-by: Jungsub Shin jungsub_shin@tmax.co.kr

When creating container that has multiple net ifaces fails
because of wrong net config, lxc doesn't remove previously created
net ifaces.

Solve this issue with changing return path in lxc_spawn().

Signed-off-by: Jungsub Shin jungsub_shin@tmax.co.kr

cmd: Fix format issues found by clang-format

list: fix indent

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

clang-format finds a few format issues, lets fix these up.

Fix format issues found by clang-format.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

cmd: Lint with cppcheck

Variable is used in one plaice only within a nested statement block.
The code is cleaner if the variable is declared near where it is used.
Found using cppcheck.

Reduce the scope of 'count' variable.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

cppcheck emits warning

  Variable 'ofd' is reassigned a value before the old one has been used.

We do not need to initialise a variable if it is assigned to on first use.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

cmd: lxc-usernsexec fixes + macro: move declarations + config_utils: macvlan fixes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: exit() => _exit()

tools: Indicate container startup failure

conf: fix path/lxcpath mixups in tty setup

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: 6947153d ("conf: use mknod() to create dummy mount target")

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

When running lxc-autostart we do not currently indicate failure to start
containers, either partial failure i.e. some of the containers failed to
start or total failure i.e. all of the containers failed to start.

Indicate container startup failure.  For total failure exit(1), for
partial failure exit(2).
Signed-off-by: Tobin C. Harding <me@tobin.cc>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Calculate length only once.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cmd: lxc-user-nic: change log macro & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: fix lxc-execute command parsing

storage/loop.c: integer overflow

The issue was introduced in PR (https://github.com/lxc/lxc/pull/1705):

Previous code:
```
  if (lseek(fd, size, SEEK_SET) < 0) {
    SYSERROR("Error seeking to set new loop file size");
    close(fd);
    return -1;
  }
```
New code:
```
  int fd, ret;

  [...]

  ret = lseek(fd, size, SEEK_SET);
  if (ret < 0) {
    SYSERROR("Failed to seek to set new loop file size for loop "
       "file \"%s\"", path);
    close(fd);
    return -1;
  }
```

Based on http://man7.org/linux/man-pages/man2/lseek.2.html:
> Upon successful completion, lseek() returns the resulting offset
> location as measured in bytes from the beginning of the file.

So in this case value of `size` and `size` is `uint64_t`.

This fix change declaration of `ret`, but it can be fixed in other ways.
Let me know what works for you.

This PR fix issues (https://github.com/lxc/lxc/issues/1872).
Signed-off-by: Lukasz Jagiello <lukasz@wikia-inc.com>

Initialize buf to avoid parsing random data later on.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage_utils: move duplicated function from tools

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

tools: add default log priority & cleanups

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>

Signed-off-by: 2xsec <dh48.jeong@samsung.com>