- 15 Dec, 2017 40 commits
-
-
Christian Brauner authored
- check for memory allocation failure - free allocated memory - cleanup function Signed-off-by:Christian Brauner <christian.brauner@ubuntu.com>
-
Jonathan Calmels authored
Signed-off-by:Jonathan Calmels <jcalmels@nvidia.com>
-
Christian Brauner authored
Moving away from internal symbols we can't do hacks like we currently do in lxc-start and call internal functions like lxc_conf_init(). This is unsafe anyway. Instead, we should simply error out if the user didn't give us a configuration file to use. lxc-start refuses to start in that case already. Relates to discussion in https://github.com/lxc/go-lxc/pull/96#discussion_r155075560 . Closes #2023. Reported-by:
Felix Abecassis <fabecassis@nvidia.com> Signed-off-by:
-
Jonathan Calmels authored
Signed-off-by: -
Christian Brauner authored
do not double close file descriptor Signed-off-by: -
Christian Brauner authored
ensure \0-termination Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
remove logically dead code Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
used calculated string length when copying into buffer Signed-off-by: -
Christian Brauner authored
fix use after free Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
This fixes a bug introduced by: commit 94f0035b Author: Christian Brauner <christian.brauner@ubuntu.com> Date: Thu Dec 7 15:07:26 2017 +0100 coverity: #1425924 remove logically dead condition Signed-off-by:
-
Stéphane Graber authored
Signed-off-by:Stéphane Graber <stgraber@ubuntu.com>
-
Marcos Paulo de Souza authored
The same message exists in lxclock.c and cgmanager.c, so print the filename along with the message. Before this patch: lxc-destroy -n u1 pthread_mutex_unlock returned:1 Operation not permitted After this patch: xc-destroy -n u1 lxclock.c: pthread_mutex_unlock returned:1 Operation not permitted Signed-off-by:Marcos Paulo de Souza <marcos.souza.org@gmail.com>
-
Christian Brauner authored
check return value of getifaddrs() Signed-off-by: -
Christian Brauner authored
do not call close on bad file descriptor Signed-off-by: -
Christian Brauner authored
silence complaint about unchecked return value from library function Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
avoid NULL-pointer dereference Signed-off-by: -
Christian Brauner authored
remove logically dead condition Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
remove logically dead code Signed-off-by: -
Christian Brauner authored
fix error condition check Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
check snprintf() return value Signed-off-by: -
Christian Brauner authored
free allocated memory Signed-off-by: -
Christian Brauner authored
use correct inequality comparison Signed-off-by: -
Christian Brauner authored
free memory on error Signed-off-by: -
Christian Brauner authored
This adds additional test for app containers. Signed-off-by: -
RicardoSanchezA authored
Signed-off-by:RicardoSanchezA <ricardo.sanchez@utexas.edu>
-
RicardoSanchezA authored
lxc_init.c should not depend on tools/arguments.{c,h}, thus it needs its own custom argument parser Signed-off-by: -
RicardoSanchezA authored
lxc_init.c is actually not a tool, thus it doesn't belong to the tools/ subfolder Signed-off-by: -
Christian Brauner authored
It doesn't make sense to error out when an app container doesn't pass explicit arguments through c->start{l}(). Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Callers can then make a decision whether they want to consider the peer closing the connection an error or not. For example, a c->wait(c, "STOPPED", -1) call can then consider a ECONNRESET not an error but rather see it - correctly - as a container exiting before being able to register a state client. Signed-off-by: -
Christian Brauner authored
This is the proper way to handle errors. Signed-off-by: -
Christian Brauner authored
If timeout is set to 0 don't block. Signed-off-by:
-
