Commits · abb6f6572c6dd48efb4e76af6f9ba7ede3db528d · Chen Yisong / lxc · GitLab

24 Feb, 2021 19 commits
- commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD · abb6f657
  Christian Brauner authored Feb 24, 2021
```
and port cgroup_get() and cgroup_set(). This means no more useless cgroup
driver initialization on ever get or set.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  abb6f657
- commands: extend rsp_one_fd() to also handle additional data · 124b60ec
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  124b60ec
- file_utils: actually open the file for reading · 53be2911
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  53be2911
- commands: set rsp.ret to 0 for lxc_cmd_get_cgroup_ctx_callback() · 28c738eb
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  28c738eb
- cgroups: s/cgroup_layout/layout/g · 61983e15
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  61983e15
- commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD · c206ac24
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c206ac24
- commands: s/_LIMITING_/_LIMIT_/g and s/_limiting_/_limit_/g · a9b642ee
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a9b642ee
- commands: simplify lxc_cmd_get_cgroup_ctx() · bce2970f
  Christian Brauner authored Feb 24, 2021
```
Instead of allowing individual hierarchy fd retrieval through
lxc_cmd_get_cgroup_ctx() let's add a dedicated method instead.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  bce2970f
- commands: fix alignment for lxc_cmd_get_cgroup_ctx() · ac5eacc6
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ac5eacc6
- cgroups: handle fallback gracefully · 8dfcf0df
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8dfcf0df
- cgroups: make use of ERRNO_IS_NOT_SUPPORTED() · f740bc63
  Christian Brauner authored Feb 24, 2021
```
This will hopefully prevent backwards compatibility fallback errors.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f740bc63
- error_utils: copy over Lennart's IN_SET() · 7924f36a
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7924f36a
- commands: tweak return values · 5dc24a8c
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5dc24a8c
- error_utils: move error helper to separate header · 38fa7e47
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  38fa7e47
- cgroups: simple variable reordering · 9d3480da
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9d3480da
- Merge pull request #3692 from brauner/2021-02-23/fixes · 5dc90afd
  Stéphane Graber authored Feb 23, 2021
```
build fix & cgroup braino
```
  5dc90afd
- attach: be paranoid about file descriptors · 6ee13f5b
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6ee13f5b
- cgroups: fix braino during controller list creation · 327baffe
  Christian Brauner authored Feb 24, 2021
```
Co-mounted controllers are conventionally separated by ",".

Fixes: https://jenkins.linuxcontainers.org/job/lxd-github-commit/1905/arch=amd64,backend=dir,compiler=golang-1.15/consoleFullSigned-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  327baffe
- commands: remove faulty use of access attribute · 70ba94fb
  Christian Brauner authored Feb 24, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  70ba94fb
23 Feb, 2021 21 commits
- Merge pull request #3691 from brauner/2021-02-23/fixes · 162402cc
  Stéphane Graber authored Feb 23, 2021
```
Fix issues reported by Coverity
```
  162402cc
- cgroups: fix error checking · 2d8b9ab8
  Christian Brauner authored Feb 23, 2021
```
Fixes: Coverity 1473310
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2d8b9ab8
- af_unix: prevent oob writes · 92fea74b
  Christian Brauner authored Feb 23, 2021
```
Fixes: Coverity 1473309
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  92fea74b
- commands: only deref once · 1454e5d9
  Christian Brauner authored Feb 23, 2021
```
Fixes: Coverity 1473308
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1454e5d9
- Merge pull request #3690 from brauner/2021-02-21/fixes · be771547
  Stéphane Graber authored Feb 23, 2021
```
attach: improve attaching of new clients to old servers
```
  be771547
- commands: handle old clients for LXC_CMD_GET_CGROUP_CTX · 7ec5eee4
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7ec5eee4
- attach: handle new and old clients · bef8f784
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  bef8f784
- attach: make fd sending more uniform · 8723f88e
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8723f88e
- terminal: dumb logging down · 550ede0a
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  550ede0a
- Merge pull request #3689 from brauner/2021-02-21/fixes · b6f48637
  Stéphane Graber authored Feb 23, 2021
```
cgroups: introduce fd-only cgroup attach via LXC_CMD_GET_CGROUP_CTX
```
  b6f48637
- attach: fix namespace preservation · 3a6678c7
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3a6678c7
- commands: verify expected file descriptors were sent · 00df5330
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  00df5330
- commands: handle older clients gracefully · 8a95cd82
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8a95cd82
- attach: remove additional newline · 7184e9d2
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7184e9d2
- af_unix: add comment about cast · 8af9b5da
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8af9b5da
- attach: fix unsupported namespaces · fb54db2c
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  fb54db2c
- commands: lxc_cmd_add_state_client_callback() · 254a22e1
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  254a22e1
- commands: handle older clients elegantly · d3be623e
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d3be623e
- commands: send ENOSYS response · ebc548a1
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ebc548a1
- cgroups: introduce fd-only cgroup attach · c071c112
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c071c112
- commands: introduce LXC_CMD_GET_CGROUP_CTX · ef6e048a
  Christian Brauner authored Feb 23, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ef6e048a