Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32475Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: handle name collisions when returning interfaces to host

oss-fuzz: fixes

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32532Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32521Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32473Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

oss-fuzz: make it possible to build the fuzzer without docker

confile: be stricter in config helpers

We never call these helper without an initialized config afaict but
since we're now exposing these two functions to oss-fuzz directly in a
way we never do to users so let's be stricter about it.

Inspired-by: #3733
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

log: dont create log file for fuzz builds

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32491Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509Suggested-by: Evgeny Vereshchagin <evvers@ya.ru>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Reviewed-by: Blair Steven <blair.steven@alliedtelesis.co.nz>
Signed-off-by: Sam Boyles <sam.boyles@alliedtelesis.co.nz>

With this patch applied the fuzz target can be built (with ASan)
and run with
```
./src/tests/oss-fuzz.sh
./out/fuzz-lxc-config-read doc/examples/
```

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32475 can be
reproduced by running
```
$ echo "lxc.console.buffer.size=d" >oss-fuzz-32475
$ ./out/fuzz-lxc-config-read ./oss-fuzz-32475
INFO: Seed: 1044753468
INFO: Loaded 1 modules   (18770 inline 8-bit counters): 18770 [0x883cc0, 0x888612),
INFO: Loaded 1 PC tables (18770 PCs): 18770 [0x888618,0x8d1b38),
./out/fuzz-lxc-config-read: Running 1 inputs 1 time(s) each.
Running: oss-fuzz-32475
=================================================================
==2052097==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffcca063e7f at pc 0x000000659e0d bp 0x7ffcca063e30 sp 0x7ffcca063e28
READ of size 1 at 0x7ffcca063e7f thread T0
...
```

I'll point OSS-Fuzz to the build script once this patch is merged.
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

oss-fuzz: fixes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32478Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32474Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32487Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

ci: turn on CIFuzz

conf: fix a memory leak

confile_utils: don't free netdev twice

Now that lxc has been integrated into OSS-Fuzz it should be
possible to start using https://google.github.io/oss-fuzz/getting-started/continuous-integration/
(mostly to make sure that the project is buildable there).

It should help to keep the integration in more or less good shape.
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

It was triggered by passing "lxc.selinux.context.keyring=xroot" to the
fuzz target introduced in https://github.com/google/oss-fuzz/pull/5498
```
=================================================================
==22==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 6 byte(s) in 1 object(s) allocated from:
    #0 0x538ca4 in __strdup /src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:468:3
    #1 0x5c40e8 in set_config_string_item /src/lxc/src/lxc/confile_utils.c:635:14
    #2 0x44394e in set_config_selinux_context_keyring /src/lxc/src/lxc/confile.c:1596:9
    #3 0x5af955 in parse_line /src/lxc/src/lxc/confile.c:2953:9
    #4 0x4475cd in lxc_file_for_each_line_mmap /src/lxc/src/lxc/parse.c:125:9
    #5 0x5af24f in lxc_config_read /src/lxc/src/lxc/confile.c:3024:9
    #6 0x580b04 in LLVMFuzzerTestOneInput /src/fuzz-lxc-config-read.c:36:2
    #7 0x483643 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
    #8 0x46d4a2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:323:6
    #9 0x4732ea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:856:9
    #10 0x49f022 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #11 0x7f16d09b883f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
```

This is a follow-up to https://github.com/lxc/lxc/commit/4fef78bc332a2d186dca6fSigned-off-by: Evgeny Vereshchagin <evvers@ya.ru>

lxc_free_netdev() will already free the list element.

Fixes: https://github.com/google/oss-fuzz/pull/5498Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

strchrnul: fix copy-paste braino

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

strchrnul: ignore increased required alignment warning

Fixes: https://jenkins.linuxcontainers.org/view/LXC/job/lxc-build-android/7949/consoleSigned-off-by: Christian Brauner <christian.brauner@ubuntu.com>

configure: fix strchrnul conditiona compilation

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

include: fix typo

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

string_utils: provide a version of strchrnul() in case it's not avail…

This should only happen on Android.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

rexec: don't close stderr