1. 10 Feb, 2019 4 commits
    • Merge pull request #2836 from brauner/2019-02-10/fix_cgfsng_driver · b49c4e2d
      Wolfgang Bumiller authored
      cgroup: bugfixes
    • cgfsng: fix cgroup creation · c74da4ab
      Christian Brauner authored
      When cgroup creation failed we reset container_cgroup to NULL to avoid
      issues with __cleanup__. Fix that logic:
      - add steal_ptr() based on take_ptr()
      - move stealing the pointer out of the loop
      
      lxc ctImport 20190210050705.858 DEBUG    network - network.c:instantiate_veth:202 - Instantiated veth "vethGQMH7I/vethSPXNL3", index is "272"
      lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1262 - File exists - Failed to create directory "/sys/fs/cgroup/unified//lxc.payload/ctImport-0"
      lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:container_create_path_for_hierarchy:1302 - Failed to create cgroup "/sys/fs/cgroup/unified//lxc.payload/ctImport-0"
      lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1431 - Failed to create cgroup "/sys/fs/cgroup/unified//lxc.payload/ctImport-0"
      lxc ctImport 20190210050705.858 INFO     cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1441 - The container uses "lxc.payload/ctImport-0" as cgroup
      lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1262 - File exists - Failed to create directory "/sys/fs/cgroup/unified/"
      lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:container_create_path_for_hierarchy:1302 - Failed to create cgroup "/sys/fs/cgroup/unified/"
      lxc ctImport 20190210050705.858 ERROR    cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1431 - Failed to create cgroup "/sys/fs/cgroup/unified/"
      lxc ctImport 20190210050705.858 INFO     cgfsng - cgroups/cgfsng.c:cgfsng_payload_create:1441 - The container uses "(null)" as cgroup
      
      Fixes: d97919ab ("cgroups: partially switch to cleanup macros")
      Reported-by: 's avatarStéphane Graber <stgraber@ubuntu.com>
      Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
  2. 09 Feb, 2019 10 commits
  3. 08 Feb, 2019 3 commits
  4. 06 Feb, 2019 23 commits