- 14 Apr, 2019 1 commit
-
-
Christian Brauner authored
The child_path variable is initialized very late in the function so jumping to the on_error label would cause a nullderef. With the cleanup macros we can simplify this function to simply do direct returns and avoid that whole issue. Closes #2935. Signed-off-by:Christian Brauner <christian.brauner@ubuntu.com>
-
- 10 Apr, 2019 39 commits
-
-
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
This adds --{disable,enable}-asan. It is disabled by default. Signed-off-by: -
Felix Abecassis authored
Fixes: #2902 Signed-off-by:Felix Abecassis <fabecassis@nvidia.com>
-
Felix Abecassis authored
Signed-off-by: -
Christian Brauner authored
This hardens multi-threaded C. Without it, the implementation of thread cancellation handlers (introduced by pthread_cleanup_push) uses a completely unprotected function pointer on the stack. This function pointer can simplify the exploitation of stack-based buffer overflows even if the thread in question is never canceled. Signed-off-by: -
Christian Brauner authored
Avoid temporary files, speeding up builds. Signed-off-by: -
Christian Brauner authored
Increased reliability of backtraces. Signed-off-by: -
Christian Brauner authored
Apparently the name received from the tree walk is not guaranteed to have \0 byte at the end. So let's make sure we append one. Note that this is only an issue if there are any subvolumes in the container's rootfs. Closes 2826. Signed-off-by: -
Christian Brauner authored
Callers such as LXD run post-stop hooks to perform cleanup operations on shutdown. This can involve umount and other things. To avoid surprises with lingering namespace references we should close all our namespace-preserving file descriptors. We don't need them at this point anymore anyway. Signed-off-by: -
Michael Sparmann authored
Signed-off-by:Michael Sparmann <theseven@gmx.net>
-
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
This reverts commit 912c4bb4. I accidently merged this commit. The initialization is wrong. Signed-off-by:
-
tomponline authored
Signed-off-by:tomponline <tomp@tomp.uk>
-
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
tomponline authored
Closes #2885. Signed-off-by: -
tomponline authored
Closes #2885. Signed-off-by: -
tomponline authored
Closes #2885. Signed-off-by: -
tomponline authored
Closes #2885. Signed-off-by: -
tomponline authored
Closes #2885. Signed-off-by: -
tomponline authored
Closes #2885. Signed-off-by: -
tomponline authored
Invalid warning but let's please the compiler. Closes lxc#2885. Signed-off-by: -
tomponline authored
Closes lxc#2885. Signed-off-by: -
Christian Brauner authored
liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <christian.brauner@ubuntu.com> Donghwa Jeong <dh48.jeong@samsung.com> Signed-off-by:
Donghwa Jeong <dh48.jeong@samsung.com>
-
Christian Brauner authored
liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <christian.brauner@ubuntu.com> Donghwa Jeong <dh48.jeong@samsung.com> Signed-off-by:
-
Christian Brauner authored
liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <christian.brauner@ubuntu.com> Donghwa Jeong <dh48.jeong@samsung.com> Signed-off-by:
-
Christian Brauner authored
liblxc has always been meant to be LGPLv2.1+ as reflected by the many downstreams projects and bindings which are themselves under LGPLv2.1+ or other licenses which would be incompatible with linking against a GPLv2+ library. It's pretty normal for a library to be LGPL while binaries are GPL as a GPL library would only ever be usable by other GPL-only projects, which isn't the case for very many of the liblxc downstreams. The issue here is really carelessness. None of those GPL headers were put there intentionally, instead being wrongly copy/pasted from other parts of the codebase which is indeed intended to be GPLv2+. This is also made clear in our CONTRIBUTING file in this repository: Licensing for new files: ------------------------ LXC is made of files shipped under a few different licenses. Anything that ends up being part of the LXC library needs to be released under LGPLv2.1+ or a license compatible with it (though the latter will only be accepted for cases where the code originated elsewhere and was imported into LXC). Language bindings for the libraries need to be released under LGPLv2.1+. Anything else (non-libraries) needs to be Free Software and needs to be allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers LGPLv2.1+ or GPLv2 for those. When introducing a new file into the project, please make sure it has a copyright header making clear under which license it's being released and if it doesn't match the criteria described above, please explain your decision on the lxc-devel mailing-list when submitting your patch. This is intended to switch over files to LGPLv2.1+ to which end we have collected ACKs from relevant people. /* Affected People */ Christian Brauner <christian.brauner@ubuntu.com> Donghwa Jeong <dh48.jeong@samsung.com> Signed-off-by:
-
Ondrej Kubik authored
Signed-off-by:Ondrej Kubik <ondrej.kubik@canonical.com>
-
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Invalid warning but let's please the compiler. Closes #2885. Signed-off-by: -
Christian Brauner authored
Closes #2885. Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Christian Brauner authored
Signed-off-by: -
Marco Dickert authored
Signed-off-by:Marco Dickert <marco@misterunknown.de>
-
Wolfgang Bumiller authored
Previously this set `ctx->ns_fd[*]` to `-EBADF` until commit fd2a88b1 ("attach: cleanup macros lxc_proc_close_ns_fd", but there are some code paths where we call this before later calling `lxc_proc_put_context_info` which would call this function again with the file descriptors still unchanged. Signed-off-by:
Wolfgang Bumiller <w.bumiller@proxmox.com>
-
