Commits · c2250e7584ad2dcffb9ebbe133f251324f8ccfd5 · Chen Yisong / lxc

10 Mar, 2020 20 commits
- Merge pull request #3285 from brauner/2020-03-10/fixes · c2250e75
  Stéphane Graber authored Mar 10, 2020
```
bugfixes
```
  c2250e75
- commands: improve state client cleanup · 39e2a438
  Christian Brauner authored Mar 10, 2020
```
Improves: ebbca852 ("commands_utils: fix socket leak when adding state client")
Cc: Matthias Hardt <matthias.hardt@gmail.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  39e2a438
- commands: switch to pid_t to send around pid · 565eb353
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  565eb353
- Merge pull request #3283 from brauner/2020-03-10/fixes · bf7e2093
  Stéphane Graber authored Mar 10, 2020
```
bugfixes
```
  bf7e2093
- share_ns: improve error handling · b41ec4d2
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b41ec4d2
- share_ns: improve error handling · 2580145f
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2580145f
- file_utils: handle libcs without fmemopen() · 7fa90630
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  7fa90630
- cgroups: cleanup · 77c3e9a2
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  77c3e9a2
- cgfsng: use __do_free_string_list all over · f761d24d
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f761d24d
- file_utils: include stdio.h for fmemopen() · e1e08f39
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e1e08f39
- tests/share_ns: always call pthread_exit() · 1b9aca11
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1b9aca11
- Merge pull request #3282 from brauner/2020-03-10/fixes · 44512eee
  Stéphane Graber authored Mar 10, 2020
```
memory_utils: remove unneeded inclusion of mntent.h
```
  44512eee
- memory_utils: remove unneeded inclusion of mntent.h · 9b53e0b7
  Christian Brauner authored Mar 10, 2020
```
Fixes: Android
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9b53e0b7
- Merge pull request #3281 from brauner/2020-03-10/fixes · 208b3ee0
  Stéphane Graber authored Mar 10, 2020
```
tree-wide: cleanup
```
  208b3ee0
- cgroups: fix memory leak and simplify code · bbba37f7
  Christian Brauner authored Mar 10, 2020
```
Closes #3252.
Reported-by: LiFeng <lifeng68@huawei.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  bbba37f7
- tests/share_ns: bugfixes · dab55f77
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  dab55f77
- conf: cleanup · 55022530
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  55022530
- commands_utils: cleanup · cdd67314
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cdd67314
- commands: cleanup · 6c6497ea
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6c6497ea
- Merge pull request #3279 from brauner/2020-03-04/improvements · 32a0f033
  Stéphane Graber authored Mar 09, 2020
```
bugfixes
```
  32a0f033
09 Mar, 2020 20 commits

tree-wide: more cleanup macros · b87ee312
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
b87ee312
lxccontainer: increase cleanup macro usage · 768e7ba2
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
768e7ba2
autotools: fix lxc-init build with clang-10 · b816bdde
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
b816bdde
tree-wide: improve logging · 818a57fc
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
818a57fc
tree-wide: make files cloexec whenever possible · 4110345b
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
4110345b
attach: cleanup various helpers · c2af3a15
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c2af3a15
attach: use logging helpers when handling no new privileges · 02d3b72b
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
02d3b72b
attach: use cleanup macros and logging helpers when fetching seccomp · cca66e06
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
cca66e06
attach: use LXC_INVALID_{G,U}ID macros · a5d657d3
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a5d657d3
attach: use cleanup macros in lxc_attach_getpwshell() · 1b9c9f5b
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
1b9c9f5b
attach: fix fd leak · cf4026f1
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
cf4026f1
attach: cleanup · ffeeed8b
Christian Brauner authored Mar 05, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ffeeed8b
cgroup2_devices: fix logic error · 874145c1
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
874145c1
commands: remove unused variables · 07e17859
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
07e17859
Merge pull request #3280 from Piscolero/state_client_socket_leak_fix · 61e9751f
Christian Brauner authored Mar 09, 2020
```
commands_utils: fix socket leak when adding state client
```
61e9751f

commands_utils: fix socket leak when adding state client · ebbca852

authored Mar 09, 2020

If lxc_add_state_client() is called with the container already being in the desired state the client fd will never be closed and is leaking. This is due to setting stay_connected in lxc_cmd for LXC_CMD_ADD_STATE_CLIENT. If the desired state isn't already achieved the client fd will later be closed by calling lxc_cmd_fd_cleanup() but in the other case the client configuration isn't added to the handlers
state clients. So the client fd has to be closed explicitely.

This is simply tested by starting container A and calling lxc-wait -n A -s RUNNING.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>

ebbca852

Revert "commands_utils: fix socket leak in when adding state client" · 2b3b8f65
Matthias Hardt authored Mar 09, 2020
```
This reverts commit d7aa5552.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>
```
2b3b8f65
Revert "commands_utils: indicate taking ownership of state_client_fd in" · ee38ab3f
Matthias Hardt authored Mar 09, 2020
```
This reverts commit cd0dc360.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>
```
ee38ab3f
commands_utils: indicate taking ownership of state_client_fd in · cd0dc360
Matthias Hardt authored Mar 09, 2020
```
lxc_add_state_client()
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>
```
cd0dc360

commands_utils: fix socket leak in when adding state client · d7aa5552

authored Mar 09, 2020

If lxc_add_state_client() is called with the container already being in
the desired state the client fd will never be closed and is leaking.
This due to setting stay_connected in lxc_cmd for
LXC_CMD_ADD_STATE_CLIENT. If the desired state isn't already achieved
the client fd will later be closed by calling lxc_cmd_fd_cleanup() but
in the other case the client configuration isn't added to the handlers
state clients. So the client fd has to be closed explicitely.

This is simply tested by starting container A and calling lxc-wait -n A
-s RUNNING.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>

d7aa5552