Commits · c89533f402c21dd62d2bb584571a2c73f4e60425 · Chen Yisong / lxc

15 Apr, 2020 10 commits

criu: make explicit that we're ignoring rmdir() return value · c89533f4
Christian Brauner authored Apr 15, 2020
```
Fixes: Coverity 1461726.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c89533f4

conf: don't double free in get_minimal_idmap() · e052e6d0

authored Apr 15, 2020

Fixes: Coverity 1461725.
Fixes: Coverity 1461727.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

e052e6d0

cgroups: use correct NULL pointer check · 6a40ccf5

authored Apr 15, 2020

Fixes: Coverity 1461722.
Fixes: Coverity 1461737.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

6a40ccf5

rexec: avoid double-close · 9c0e2551

authored Apr 15, 2020

Fixes: Coverity 1461721.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

9c0e2551

cgroups: fix cgroup2 devices · bc15baac

authored Apr 15, 2020

Fixes: Coverity 1461748.
Fixes: Coverity 1461746.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bc15baac

uuid: close fd · a4ccd3a7

authored Apr 15, 2020

Fixes: Coverity 1461751.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

a4ccd3a7

cgroups: do not pass NULL pointer · 86652cfb
Christian Brauner authored Apr 15, 2020
```
Fixes: Coverity 1461752.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
86652cfb

conf: fix tty cleanup · 6810da44

authored Apr 15, 2020

Fixes: Coverity 1461755.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

6810da44

memory_utils: directly NULL ptr in free_disarm() · c7c55c1a

authored Apr 15, 2020

This should keep coverity happy.

Fixes: Coverity 1461757.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

c7c55c1a

travis: add back coverity · 3769a87b
Christian Brauner authored Apr 15, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
3769a87b

14 Apr, 2020 4 commits

cgroup: fix wrong use of cgfd_con in cgroup_exit · 4a248480
LiFeng authored Apr 13, 2020
```
Signed-off-by: LiFeng <lifeng68@huawei.com>
```
4a248480

Fix lxc-oci template with loop backingstore · a7723234

authored Apr 12, 2020

Move the content of rootfs inside OCI package to rootfs instead of
replacing it, as the directory is used as the mountpoint.

Tested with directory and loop backingstore.
Signed-off-by: Toni Ylenius <toni.ylenius@iki.fi>

a7723234

cgroups: ignore legacy limits on pure cgroup2 systems · 16ccd6eb

authored Apr 12, 2020

Link: https://github.com/lxc/lxc/issues/3183#issuecomment-612462322Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

16ccd6eb

tests/no-new-privs: Don't mess with /etc/lxc · ec84b86e
Stéphane Graber authored Apr 11, 2020
```
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
ec84b86e

10 Apr, 2020 1 commit
- lxc-update-config: Fix bad handling of lxc.logfile · 43ff9c68
  Stéphane Graber authored Apr 10, 2020
```
Closes #3369
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
  43ff9c68
09 Apr, 2020 11 commits
- conf: move_ptr() in all cases in mapped_hostid_add() · 2a4fed96
  Christian Brauner authored Apr 09, 2020
```
Closes #3366.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2a4fed96
- conf: use macros all around in lxc_map_ids() · 37fcb9bc
  Christian Brauner authored Apr 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  37fcb9bc
- conf: tweak get_minimal_idmap() · 3b7f02fa
  Christian Brauner authored Apr 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3b7f02fa
- src/lxc/network: ipvlan comment and code style tweak · 53cffd75
  Thomas Parrott authored Apr 09, 2020
```
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
```
  53cffd75
- network: Make it possible to set the mode of IPVLAN to L2 · b2722ecb
  KUWAZAWA Takuya authored Apr 09, 2020
```
Signed-off-by: KUWAZAWA Takuya <albatross0@gmail.com>
```
  b2722ecb
- seccomp: newer kernels require the buffer to be zeroed · c2e3e9a4
  Christian Brauner authored Apr 08, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c2e3e9a4
- cgroups: whitespace fixes · eb8d7c09
  Christian Brauner authored Apr 08, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  eb8d7c09
- lxc_user_nic: continue when we failed to find a group · 57169400
  Christian Brauner authored Apr 07, 2020
```
Closes #3361.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  57169400
- lxc_user_nic: simplify group retrieval · e8bb9e4f
  Christian Brauner authored Apr 07, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e8bb9e4f
- syscall_numbers: handle riscv · 468797a3
  Christian Brauner authored Apr 07, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  468797a3
- start: ensure all file descriptors are closed during exec · 850c0659
  Christian Brauner authored Apr 07, 2020
```
Closes https://github.com/checkpoint-restore/criu/issues/1011.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  850c0659
06 Apr, 2020 2 commits

Release LXC 4.0.1 · 98613f61
Stéphane Graber authored Apr 06, 2020
```
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
98613f61

Revert "start: remove unnecessary check for valid cgroup_ops" · d33bb0fe

authored Apr 03, 2020

This reverts commit 52520e4f.

This can be NULL when there's a pre-start hook which fails.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

d33bb0fe

02 Apr, 2020 6 commits

lxccontainer: poll takes millisecond not seconds · 7e67b81d
Christian Brauner authored Apr 02, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
7e67b81d

cgroups: fix build warning on GCC 7 · b5d3501f

authored Apr 03, 2020

GCC 7 appears to be clever enough to detect that transient_len is
uninitialised but not that it won't be used despite [1]. Just initialise
it to zero to stop the complaining, and allow LXC to build on openSUSE
Leap.

[1]: 34683042 ("cgroups: fix "uninitialized transient_len" warning")
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>

b5d3501f

utils: use setres{u,g}id() in lxc_switch_uid_gid() · 05bec191
Christian Brauner authored Apr 02, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
05bec191
utils: rework fix_stdio_permissions() · 9ae55948
Christian Brauner authored Apr 02, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
9ae55948

cgroups: fix "uninitialized transient_len" warning · 256d4d01

authored Apr 02, 2020

Without this change, a build error is triggered if you compile with
-Werror=maybe-uninitialized.

 cgroups/cgfsng.c: In function 'cgfsng_monitor_enter':
 groups/cgfsng.c:1387:9: error: 'transient_len' may be used uninitialized in this function
    ret = lxc_writeat(h->cgfd_mon, "cgroup.procs", transient, transient_len);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The issue is that if handler->transient_pid is 0, then transient_len is
uninitialised but lxc_writeat(..., transient_len) still gets called.
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>

256d4d01

fix non-root user cannot write /dev/stdout · b9d08129
gaohuatao authored Apr 01, 2020
```
Signed-off-by: gaohuatao <gaohuatao@huawei.com>
```
b9d08129

01 Apr, 2020 5 commits
- systemd: Add Documentation key · fa7132ae
  Stéphane Graber authored Apr 01, 2020
```
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
  fa7132ae
- autotools: don't install run-coccinelle.sh · e6c5d2e4
  Christian Brauner authored Apr 01, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e6c5d2e4
- apparmor: generate ro,bind,remount rule list · 4e43c4fb
  Wolfgang Bumiller authored Aug 02, 2019
```
and update to changes based on lxd
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
```
  4e43c4fb
- init: add ExecReload to lxc.service to only reload profiles · 5697d2c6
  Wolfgang Bumiller authored Mar 31, 2020
```
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
```
  5697d2c6
- start: remove unnecessary check for valid cgroup_ops · 46340ce2
  Christian Brauner authored Mar 30, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  46340ce2
30 Mar, 2020 1 commit
- cgroups: send two fds to attach to unified cgroup · 179e2bf8
  Christian Brauner authored Mar 30, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  179e2bf8