Commits · c92a2062f441977f6166e6891a5bbc1905724ce4 · Chen Yisong / lxc

10 Dec, 2018 40 commits

coverity: #438136 · c92a2062

authored Jul 31, 2018

String not null terminated
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

c92a2062

caps: handle EINTR in read() · b608a3d9

authored Jul 29, 2018

We don't want to link caps.{c,h} against utils.{c,h} for the sake of our static
builds init.lxc.static. This means lxc_write_nointr() will not be available. So
handle it EINTR.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

b608a3d9

log: handle EINTR in read() · c66853b8

authored Jul 29, 2018

We don't want to link log.{c,h} against utils.{c,h} for the sake of our static
builds init.lxc.static. This means lxc_write_nointr() will not be available. So
handle it EINTR.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

c66853b8

sync: s/write()/lxc_write_nointr()/g · 9345a898
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
9345a898
sync: s/read()/lxc_read_nointr()/g · d98d27e2
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
d98d27e2
network: s/write()/lxc_write_nointr()/g · e3a9bfbf
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
e3a9bfbf
network: s/read()/lxc_read_nointr()/g · 089ad11c
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
089ad11c
lxccontainer: s/read()/lxc_read_nointr()/g · a11cad82
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a11cad82
lxccontainer: s/write()/lxc_write_nointr()/g · ba0ac146
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ba0ac146
criu: s/write()/lxc_write_nointr()/g · 41d8fd0f
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
41d8fd0f
criu: s/read()/lxc_read_nointr()/g · 95bc087f
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
95bc087f
cmd: s/read()/lxc_read_nointr()/g · d2bd14f0
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
d2bd14f0
cmd: s/write()/lxc_write_nointr()/g · 41b1a847
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
41b1a847
cmd: s/pipe()/pipe2()/g · c14d9ffe
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c14d9ffe
lxccontainer: s/pipe()/pipe2()/g · 0e8afcc0
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
0e8afcc0
lxccontainer: cleanup do_lxcapi_get_interfaces() · 988c11f7
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
988c11f7
criu: s/pipe()/pipe2()/ · 705f5735
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
705f5735
conf: always close pipe in run_userns_fn() · 7a12b86c
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
7a12b86c
conf: s/pipe()/pipe2()/g · 3c887fcb
Christian Brauner authored Jul 29, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
3c887fcb

nl: avoid NULL pointer dereference · cba71d52

authored Jul 29, 2018

It's a valid case to call nla_put() with NULL data and 0 len. It's done e.g. in
the nla_put_attr().

There has to be a check for data in nla_put() as passing NULL to the memcpy()
is not allowed. Even if length is 0, both pointers have to be valid.

For a reference see C99 standard (7.21.1/2), it says: "pointer arguments on
such a call shall still have valid values".
Reported-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
[christian.brauner@ubuntu.com: adapted commit message]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cba71d52

change log macro of error case from lxc_ambient_caps_up/down · a1b60d34
2xsec authored Jul 22, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
a1b60d34

coverity: #1438067 · a16d90b5

authored Jul 21, 2018

Explicit null dereferenced
Signed-off-by: 2xsec <dh48.jeong@samsung.com>

a16d90b5

conf: the atime flags are locked in userns · cacde1a9

authored Jul 18, 2018

This means they need to be added for remount and for fresh mounts.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cacde1a9

lxclock: change error log using strerror to SYSERROR · 2e264c85
2xsec authored Jul 13, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
2e264c85

coverity: #1437935 · f0127c98

authored Jul 12, 2018

Unchecked return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

f0127c98

coverity: #1437936 · dd4ad068

authored Jul 12, 2018

Unchecked return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

dd4ad068

attach: simplify lxc_attach_getpwshell() · b789a324
Christian Brauner authored Jul 11, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
b789a324
log: thread-safety backports · c619ba29
Christian Brauner authored Dec 10, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c619ba29
start: don't unconditionally open("/dev/null") · 535ceb0b
Christian Brauner authored Jul 09, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
535ceb0b

coverity: #1425816 · 3a8d6b64

authored Jul 02, 2018

Explicit null dereferenced
Signed-off-by: 2xsec <dh48.jeong@samsung.com>

3a8d6b64

CODING_STYLE: add section about using strlcat() · c13a1a0a
Christian Brauner authored Jun 30, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c13a1a0a
log: account for Android's Bionic's strerror_r() · 18284699
Christian Brauner authored Jun 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
18284699

log: add lxc_log_strerror_r macro · 14a740a6

authored Jun 25, 2018

Let's ensure that we always use the thread-safe strerror_r() function and add
an approriate macro.
Additionally, define SYS*() macros for all log levels. They will use the new
macro and ensure thread-safe retrieval of errno values.
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
[christian.brauner@ubuntu.com: simplify lxc_log_strerror_r macro]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

14a740a6

move some comments in lxc.spec.in · f1f839b8
2xsec authored Jun 25, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
f1f839b8
monitor: change exit() => _exit() system call in child process · d3ff0fdf
2xsec authored Jun 22, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
d3ff0fdf
commands: simplify lxc_cmd() · ebd961d2
Christian Brauner authored Jun 22, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ebd961d2
fix pointer c is dereferenced after checking null · a3d67822
Donghwa Jeong authored Jun 19, 2018
```
Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>
```
a3d67822
fix fd handle leak · 743a2994
Donghwa Jeong authored Jun 19, 2018
```
Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>
```
743a2994
secure coding: #2 strcpy => strlcpy · 7a3e2867
Donghwa Jeong authored Jun 18, 2018
```
Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>
```
7a3e2867
btrfs: fix get_btrfs_subvol_path() · 0c4826e3
Christian Brauner authored Dec 10, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
0c4826e3