Commits · cfc0a48ea2162f5377edd5d19f4e1c8e6f0adf66 · Chen Yisong / lxc

06 Apr, 2021 13 commits
- conf: fix setups where /dev is outside of LXC's control · cfc0a48e
  Christian Brauner authored Apr 06, 2021
```
Fixes: #3770
Suggested-by: Ruben Jenster <r.jenster@drachenfels.de>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cfc0a48e
- confile: complain when LXC is built without AppArmor support · 448462dd
  Christian Brauner authored Apr 02, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  448462dd
- confile: complain when LXC is built without selinux support · 029dff4a
  Christian Brauner authored Apr 02, 2021
```
Link: https://github.com/lxc/lxc/issues/3765Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  029dff4a
- confile: fix lxc.namespace.share.[identifier] · f4f2fc2c
  Christian Brauner authored Apr 02, 2021
```
Link: https://github.com/lxc/lxc/pull/3763/files#r606089660Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f4f2fc2c
- confile: simplify get_network_config_ops() · cea4f8d9
  Christian Brauner authored Apr 01, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cea4f8d9
- string_utils: use restrict for lxc_safe_int64_residual() · 497b1a2b
  Christian Brauner authored Apr 01, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  497b1a2b
- string_utils: ensure that errno is set on return · 5f1d274c
  Christian Brauner authored Apr 01, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5f1d274c
- string_utils: move to lxc-copy() sources · 98e8508c
  Christian Brauner authored Apr 01, 2021
```
It's the only place where it is still used.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  98e8508c
- lxc_user_nic: cleanup get_alloted() · c0a515a3
  Christian Brauner authored Mar 31, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c0a515a3
- lxc_user_nic: cleanup append_alloted() · f21078df
  Christian Brauner authored Mar 31, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f21078df
- confile: cap to last bit in set_config_net_ipv4_address() · 1f2cdd46
  Christian Brauner authored Mar 31, 2021
```
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32708Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1f2cdd46
- string_utils: switch to path_simplify() · 636a1558
  Christian Brauner authored Mar 30, 2021
```
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32689Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  636a1558
- confile: don't jump into the global table twice · 589e8224
  Christian Brauner authored Mar 30, 2021
```
instead move networking keys into a subtable. This avoids even just the
remote danger of recursion and also speeds up config parsing.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  589e8224
02 Apr, 2021 10 commits
- oss-fuzz: reject giant configs early · 2f593756
  Evgeny Vereshchagin authored Mar 30, 2021
```
It should help the fuzzer to avoid running into timeouts
like https://oss-fuzz.com/testcase-detail/5132999948632064.
Hopefully, once this is merged OSS-Fuzz will report only
infinite loops as timeouts.
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  2f593756
- build-system: make it compatible with ASan/UBsan/MSan · 52c57882
  Evgeny Vereshchagin authored Mar 30, 2021
```
Closes: https://github.com/lxc/lxc/issues/3727Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  52c57882
- ci: enable PAM · 85ec1b47
  Evgeny Vereshchagin authored Mar 30, 2021
```
to make sure pam_cgfs is buildable with ASan/UBsan too
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  85ec1b47
- ci: also build with ASan/UBsan · 766b5f05
  Evgeny Vereshchagin authored Mar 30, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  766b5f05
- oss-fuzz.sh: get rid of the sed "no-undefined" kludge · fe069142
  Evgeny Vereshchagin authored Mar 30, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  fe069142
- ci: stop passing --enable-ubsan · b2378a56
  Evgeny Vereshchagin authored Mar 30, 2021
```
It's just a follow-up to 5f404236 (where --enable-ubsan
was removed).
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  b2378a56
- doc: Documented that net type field must come before other options on the net device · df9bfcf0
  Thomas Parrott authored Mar 29, 2021
```
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
```
  df9bfcf0
- README: remove Travis and add Github actions badge · 38743a89
  Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  38743a89
- autotools: remove --enable-{asan,ubsan} in favor of --enable-sanitizers · 96c61d3a
  Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  96c61d3a
- oss-fuzz.sh: put the "lxc.net" keys in the seed corpus as well · 95e142f5
  Evgeny Vereshchagin authored Mar 29, 2021
```
It's just a follow-up to 0abcc213 (where the "lxc.net" keys
were moved from config_jump_table to config_jump_table_net)
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
  95e142f5
29 Mar, 2021 17 commits

compiler: fix thread_local detection · 03fd6796
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
03fd6796
lxccontainer: ensure second parameter to bsearch is never NULL · 3d764767
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
3d764767

conf: fix thread_local support detection · 63340988

authored Mar 29, 2021

Our detection for TLS wasn't working. Fix it.

Fixes: https://github.com/lxc/lxd/issues/8327Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

63340988

tests: add another test for garbage config key · 90accff3

authored Mar 29, 2021

where a valid key has trailing garbage at the end before the "=".
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

90accff3

tests: fix two false negatives in parse_config_file() · f44eb244
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
f44eb244
confile: cleanup set_config_net_script_down() · 01e3ca9b
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
01e3ca9b
confile: cleanup set_config_net_script_up() · ab34ded6
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ab34ded6
confile: cleanup set_config_net_mtu() · d47e3831
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
d47e3831
confile: cleanup set_config_net_hwaddr() · c72590da
Christian Brauner authored Mar 29, 2021
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c72590da

confile: clear netdev on network type change · 942b2d31

authored Mar 29, 2021

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32584Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

942b2d31

confile: vet keys more aggressively · 24ca9420

authored Mar 29, 2021

Enforce an exact match for all keys where we now the subkeys must match
exactly.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

24ca9420

confile: safely clean previous value in set_config_net_ipv4_gateway() · 9d5a073d

authored Mar 28, 2021

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32586Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

9d5a073d

confile: safely clean previous value in set_config_net_ipv6_gateway() · ed3a03cb

authored Mar 28, 2021

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32610Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

ed3a03cb

string_utils: work around an MSan false positive · a348e8f4

authored Mar 28, 2021

MSan doesn't instrument stpncpy (https://github.com/google/sanitizers/issues/926),
which causes the fuzzer to fail with:
```
$ cat ../minimized-from-740f56329efc60eab59b8194132b712a873e88a3
lxc.console.size=123

$ ./out/fuzz-lxc-config-read ../minimized-from-740f56329efc60eab59b8194132b712a873e88a3
INFO: Seed: 3561494591
INFO: Loaded 1 modules   (18795 inline 8-bit counters): 18795 [0x866b98, 0x86b503),
INFO: Loaded 1 PC tables (18795 PCs): 18795 [0x86b508,0x8b4bb8),
./out/fuzz-lxc-config-read: Running 1 inputs 1 time(s) each.
Running: ../minimized-from-740f56329efc60eab59b8194132b712a873e88a3
==850885==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x6b3e7f in parse_byte_size_string /home/vagrant/lxc/src/lxc/string_utils.c:912:6
    #1 0x550991 in set_config_console_size /home/vagrant/lxc/src/lxc/confile.c:2483:8
    #2 0x5346e2 in parse_line /home/vagrant/lxc/src/lxc/confile.c:2962:9
    #3 0x64b3cd in lxc_file_for_each_line_mmap /home/vagrant/lxc/src/lxc/parse.c:125:9
    #4 0x53340c in lxc_config_read /home/vagrant/lxc/src/lxc/confile.c:3039:9
    #5 0x4e7ec2 in LLVMFuzzerTestOneInput /home/vagrant/lxc/src/tests/fuzz-lxc-config-read.c:23:2
    #6 0x44ad2c in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x44ad2c)
    #7 0x42ca4d in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x42ca4d)
    #8 0x433af0 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x433af0)
    #9 0x423ff6 in main (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x423ff6)
    #10 0x7f79bdc89081 in __libc_start_main (/lib64/libc.so.6+0x27081)
    #11 0x42402d in _start (/home/vagrant/lxc/out/fuzz-lxc-config-read+0x42402d)

  Uninitialized value was created by an allocation of 'dup' in the stack frame of function 'parse_byte_size_string'
    #0 0x6b3330 in parse_byte_size_string /home/vagrant/lxc/src/lxc/string_utils.c:901

SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/vagrant/lxc/src/lxc/string_utils.c:912:6 in parse_byte_size_string
Exiting
```

Closes https://oss-fuzz.com/testcase-detail/5829890470445056Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>

a348e8f4

cifuzz: turn on MSan · 0e24c1b2
Evgeny Vereshchagin authored Mar 28, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
0e24c1b2

string_utils: handle overflow correct in parse_byte_size_string() · 8ccd3d76

authored Mar 27, 2021

This takes the overflow handling code from the kernel.

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32549Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

8ccd3d76

cifuzz: turn on UBsan · 51b0e727
Evgeny Vereshchagin authored Mar 28, 2021
```
Signed-off-by: Evgeny Vereshchagin <evvers@ya.ru>
```
51b0e727