Commits · d4b5308d3a637aabefe61898b5083efee2baae03 · Chen Yisong / lxc

22 Aug, 2018 2 commits

log: handle strerror_r() versions · d4b5308d
Christian Brauner authored Aug 22, 2018
```
Closes #2563.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
d4b5308d

autotools: check if compiler is new enough · 5ac017fb

authored Aug 22, 2018

We line up with the Linux kernel and won't support any compiler under 4.6.
Additionally, we also require at least gnu99 so this is due anyway.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

5ac017fb

21 Aug, 2018 23 commits

Makefile: don't allow undefined symbols · 28f1d8bb
Christian Brauner authored Aug 21, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
28f1d8bb
macro: move macros from attach.c · e60ea2f6
Christian Brauner authored Aug 21, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
e60ea2f6
attach: move struct declaration to top · 125541cd
Christian Brauner authored Aug 21, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
125541cd
macro: s/rexit()/_exit()/g · 5c28be22
Christian Brauner authored Aug 21, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
5c28be22
conf: fix devpts mounting when fully unprivileged · ca4eb982
Christian Brauner authored Aug 21, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ca4eb982
pam_cgfs: build from the same sources as liblxc · e9cab3e7
Christian Brauner authored Aug 21, 2018
```
Closes #2556.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
e9cab3e7
utils: split into {file,string}_utils.{c,h} · bcd0f26c
Christian Brauner authored Aug 21, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
bcd0f26c
list: fix indent · a03bd5d6
2xsec authored Aug 21, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
a03bd5d6

cmd: Fix format issues found by clang-format · 8b0e52e7

authored Aug 21, 2018

clang-format finds a few format issues, lets fix these up.

Fix format issues found by clang-format.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

8b0e52e7

cmd: Reduce scope of 'count' variable · 0be127e0

authored Aug 20, 2018

Variable is used in one plaice only within a nested statement block.
The code is cleaner if the variable is declared near where it is used.
Found using cppcheck.

Reduce the scope of 'count' variable.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

0be127e0

cmd: Do not reassign variable before it is used · fddd112c

authored Aug 20, 2018

cppcheck emits warning

  Variable 'ofd' is reassigned a value before the old one has been used.

We do not need to initialise a variable if it is assigned to on first use.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

fddd112c

cmd: use goto for cleanup in lxc-usernsexec · 349df8e3
Christian Brauner authored Aug 20, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
349df8e3

conf: fix path/lxcpath mixups in tty setup · 0cf1cbf2

authored Aug 20, 2018

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: 6947153d ("conf: use mknod() to create dummy mount target")

0cf1cbf2

tools: lxc-wait: add default log priority & cleanups · 152c0dc8
2xsec authored Aug 20, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
152c0dc8
storage: exit() => _exit(). when exec is failed, child process needs to use _exit() · bc2c01a1
2xsec authored Aug 20, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
bc2c01a1

tools: Indicate container startup failure · fbdcc1b4

authored Aug 17, 2018

When running lxc-autostart we do not currently indicate failure to start
containers, either partial failure i.e. some of the containers failed to
start or total failure i.e. all of the containers failed to start.

Indicate container startup failure.  For total failure exit(1), for
partial failure exit(2).
Signed-off-by: Tobin C. Harding <me@tobin.cc>

fbdcc1b4

macro: add macvlan properties · 48095dd4
Christian Brauner authored Aug 19, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
48095dd4
macro: add missing headers · 3991c6f9
Christian Brauner authored Aug 19, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
3991c6f9
cmd: use safe number parsers in lxc-usernsexec · 71219fea
Christian Brauner authored Aug 19, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
71219fea

cmd: simplify lxc-usernsexec · c9b62848

authored Aug 19, 2018

Calculate length only once.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

c9b62848

cmd: use utils.{c,h} helpers in lxc-usernsexec · 73572438
Christian Brauner authored Aug 19, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
73572438
cmd: move declarations to macro.h · a819b385
Christian Brauner authored Aug 19, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a819b385
cmd: lxc-usernsexec reorder includes · e18ab019
Christian Brauner authored Aug 19, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
e18ab019

19 Aug, 2018 15 commits

cmd: lxc-user-nic: change log macro & cleanups · c46ce04b
2xsec authored Aug 19, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
c46ce04b

lseek - integer overflow · 5b29b6a7

authored Aug 18, 2018

The issue was introduced in PR (https://github.com/lxc/lxc/pull/1705):

Previous code:
```
  if (lseek(fd, size, SEEK_SET) < 0) {
    SYSERROR("Error seeking to set new loop file size");
    close(fd);
    return -1;
  }
```
New code:
```
  int fd, ret;

  [...]

  ret = lseek(fd, size, SEEK_SET);
  if (ret < 0) {
    SYSERROR("Failed to seek to set new loop file size for loop "
       "file \"%s\"", path);
    close(fd);
    return -1;
  }
```

Based on http://man7.org/linux/man-pages/man2/lseek.2.html:
> Upon successful completion, lseek() returns the resulting offset
> location as measured in bytes from the beginning of the file.

So in this case value of `size` and `size` is `uint64_t`.

This fix change declaration of `ret`, but it can be fixed in other ways.
Let me know what works for you.

This PR fix issues (https://github.com/lxc/lxc/issues/1872).
Signed-off-by: Lukasz Jagiello <lukasz@wikia-inc.com>

5b29b6a7

tools: fix lxc-execute command parsing · 56e193a6

authored Aug 18, 2018

Initialize buf to avoid parsing random data later on.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

56e193a6

storage_utils: move duplicated function from tools · 431ff1ca
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
431ff1ca
tools: lxc-unfreeze: add default log priority & cleanups · 5dbf9d77
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
5dbf9d77
tools: lxc-freeze: add default log priority & cleanups · 47d6b8f7
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
47d6b8f7
tools: lxc-stop: add default log priority & cleanups · 1e764f80
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
1e764f80
tools: lxc-start: add default log priority & cleanups · 765604fa
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
765604fa
tools: lxc-execute: add default log priority & cleanups · bb19d0ab
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
bb19d0ab
tools: lxc-device: add default log priority & cleanups · 3920d874
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
3920d874
tools: lxc-destroy: add default log priority & cleanups · a1fe06d6
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
a1fe06d6
tools: lxc-create: add default log priority & cleanups · c141d481
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
c141d481
tools: lxc-console: add default log priority & cleanups · d0e1b257
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
d0e1b257
tools: lxc-checkpoint: add default log priority & cleanups · 83a5624a
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
83a5624a
tools: lxc-cgroup: add default log priority & cleanups · eda2d856
2xsec authored Aug 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
eda2d856