terminal: bugfixes

Closes: https://github.com/lxc/lxd/issues/6408Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-usernsexec: support easily mapping own uid

Signed-off-by: Serge Hallyn <shallyn@cisco.com>

tests: add tests making sure the exit code is appropriate.

lxc2 broke this feature for lxc-execute, and lxc3 broke it for
lxc-attach. This adds a test making sure we don't do the same mistake
a third time.
Signed-off-by: Florian Margaine <florian@platform.sh>

terminal: return NULL on error in terminal_signal_init

Callers expect a NULL on error, and with PR #3171 marking
the pointer as __do_free, we now return a pointer to freed
memory here otherwise.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

terminal: prevent memory leak for lxc_terminal_state

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

apparmor: Prevent writes to /proc/acpi/**

Same as #3117.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

syscall_wrappers: rename internal memfd_create to memfd_create_lxc

In case the internal memfd_create has to be used, make sure we don't
clash with the already existing memfd_create function from glibc.

This can happen if this glibc function is a stub. In this case, at
./configure time, the test for this function will return false, however
the declaration of that function is still available. This leads to
compilation errors.
Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>

lxc/tools/lxc/destroy: Restores error message on container destroy

Partially reverts 65b92ea5 so that trying to destroy a non-existent container gives an error message.
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

Update lxc.containers.conf(5) in Japanese

Update for commit 767bd70aSigned-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Bad sgml/man translation

When calling "man lxc.container.conf", an internal "man" keyword is displayed :

$ man lxc.container.conf
[...]
lxc.mount.entry
              Specify a mount point corresponding to a line in the fstab format.  Moreover lxc supports mount  propagation,  such  as
              rslave  or  rprivate, and adds three additional mount options.  optional don't fail if mount does not work.  create=dir
              or create=file to create dir (or file) when the point will be mounted.  relative source path is taken to be relative to
              the mounted container root. For instance,

dev/null proc/kcore none bind,relative 0 0
              .fi     <-----------------------------------UNEXPECTED KEYWORD !!!!

The problem seems to come from the missing blanks before "dev/null proc/kcore none bind,relative 0 0"

Moreover, for homogeneity purposes, it is better to use the "programlisting" tag used in the rest of the text instead of  "screen".
Signed-off-by: Rachid Koucha <rachid.koucha@gmail.com>

Update Japanese lxc.container.conf(5)

Update for commit 0684250fSigned-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Update for commit 63012bddSigned-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Send successful output messages to log info instead of error

Signed-off-by: Caio B. Silva <caioboffo@gmail.com>

doc: Add more info about 'lxc.start.order'

Signed-off-by: Lukas Jelinek <lukas.jelinek@nic.cz>

Autoconf 2.69 conformance II 

Signed-off-by: Caio B. Silva <caioboffo@gmail.com>

Add config parameter for /dev tmpfs size

Signed-off-by: Claudio Kuenzler <ck@claudiokuenzler.com>

start: handle setting pdeath signal in new pidns

In the usual case the child runs in a separate pid namespace. So far we haven't
been able to reliably set the pdeath signal. When we set the pdeath signal we
need to verify that we haven't lost a race whereby we have been orphaned and
though we have set a pdeath signal it won't help us since, well, the parent is
dead.
We were able to correctly handle this case when we were in the same pidns since
getppid() will return a valid pid. When we are in a separate pidns 0 will be
returned since the parent doesn't exist in our pidns.
A while back, while Jann and I were discussing other things he came up with a
nifty idea: simply pass an fd for the parent's status file and check the
"State:" field. This is the implementation of that idea.
Suggested-by: Jann Horn <jann@thejh.net>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: pidfds obviously start - like any fd - at 0

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Fix lxc-update-config in network.address

Signed-off-by: Alban VIDAL <zordhak@debian.org>

Autoconf 2.69 conformance

allow users to configure the option --enable-feature or --with-package, if an option is given run shell commands action-if-given
Signed-off-by: Caio B. Silva <caioboffo@gmail.com>