Commits · e1ff30a9a8ca20e43fcddbb3e217c472f97d91aa · Chen Yisong / lxc

15 Dec, 2017 40 commits

commands: don't traverse whole list · e1ff30a9

authored Nov 22, 2017

When we remove a state client fd there's not reason to walk the whole list. We
can simply break once we found and removed the fd.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

e1ff30a9

start: set loglevel correctly · b6ebd1f2

authored Dec 06, 2017

We want the loglevel that the user specified when starting the container
because it overrides the default one set in the config.

Closes #2003.
Reported-by: Felix Abecassis <fabecassis@nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

b6ebd1f2

arguments: move to tools/ subdirectory · 07b6e2e6

authored Dec 04, 2017

The arguments.{c,h} file should not be a part of liblxc itself. It should only
be used for the lxc tools.
Signed-off-by: RicardoSanchezA <ricardo.sanchez@utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

07b6e2e6

lxc_execute: properly figure out number of needed arguments · bab5c748

authored Dec 04, 2017

The lxc_log args have noghing to do with lxc.rootfs.path, and
we need room for a NULL at end of arguments.

How this bug was hidden for so long I don't know - I can only
trigger it on certain systems under certain conditions, but it's
definately wrong as is.
Signed-off-by: Serge Hallyn <shallyn@cisco.com>

bab5c748

test: reenable Coverity integration · 88c42f50
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
88c42f50
attach: do not fail on non-existing namespaces · 77d82ac6
Christian Brauner authored Dec 04, 2017
```
Closes #1993.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
77d82ac6
criu: silence static analysis · 5760a5a0
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
5760a5a0
confile: remove dead assignment · fb1f9a9d
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
fb1f9a9d
criu: initialize status · 449af9a0
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
449af9a0
confile_legacy: prevent null pointer deref · 57d668df
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
57d668df
conf: prevent null pointer dereference · 053ec268
Christian Brauner authored Dec 04, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
053ec268
Insert missing "echo" after "is_enabled" · cbe31267
Pierre LALET authored Dec 03, 2017
```
Signed-off-by: Pierre LALET <pierre.lalet@cea.fr>
```
cbe31267
Fix SETCOLOR_FAILURE evaluation · 348f192d
Pierre LALET authored Dec 03, 2017
```
Signed-off-by: Pierre LALET <pierre.lalet@cea.fr>
```
348f192d

Add bash completion to list backing store types for lxc-create -B · 68251bd6

authored Dec 03, 2017

- Backing Store types are hard-coded (Not sure how to get programmatically)
- Closes #1236
Signed-off-by: Abbas Ally <abbasally5@yahoo.com>

68251bd6

Add new dependency to Slackware template · 314697b8

authored Dec 02, 2017

I followed the [changelog of Slackware-current]<http://www.slackware.com/changelog/>,
and found that Slackware-current split hostname utility from util-linux package in Nov 17 2017.
So I add the new package to the template.
Signed-off-by: Chia-Chun Hsu <a12321aabb@gmail.com>

314697b8

Update gentoo.moresecure.conf. · 19f90d53

authored Dec 02, 2017

Closes https://github.com/lxc/lxc/issues/1928Signed-off-by: i.Dark_Templar <darktemplar@dark-templar-archives.net>

19f90d53

lxc_unshare: Add uid_mapping when creating userns · 28f7670c

authored Nov 28, 2017

Change conf.c to export function write_id_mapping, which will now be
called inside main function of lxc_unshare.c.

This is required because setuid syscalls only permits a new userns to
set a new uid if the uid of parameter is mapped inside the ns using
uid_map file[1]. So, just after the clone invocation, map the uid passed as
parameter into the newly created user namespace, and put the current uid
as the ID-outside-ns. After the mapping is done, setuid call succeeds.

Closes: #494

[1] https://elixir.free-electrons.com/linux/latest/source/kernel/user_namespace.c#L286Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

28f7670c

utils: declare sethostname() static inline · eb59c469
Christian Brauner authored Dec 01, 2017
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
eb59c469

confile_utils: simplify lxc_config_net_hwaddr · 0a210f86

authored Nov 28, 2017

In addition to the memory corruption fixed in ee3e84df,
this function was also performing invalid memory accesses for the following inputs:
- `lxc.net`
- `lxc.net.`
- `lxc.net.0.`
- `lxc.network`
- `lxc.network.0.`
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

0a210f86

confile: error out if a network configuration key has no subkey · 0a7f6089

authored Nov 28, 2017

This prevent an infinite recursion in the case of "lxc.net.0. = a"
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

0a7f6089

log: fix infinite loop with multiple lxc.log.syslog keys · 46efc088

authored Nov 28, 2017

This caused the linked list of appenders to loop on itself, creating
an infinite logging loop in `__lxc_log_append`.
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

46efc088

tests: add a function for negative netdev tests · cd70a8ed
Felix Abecassis authored Nov 28, 2017
```
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
```
cd70a8ed
confile: fix memory leak · 192ab19d
Felix Abecassis authored Nov 28, 2017
```
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
```
192ab19d
tools/lxc_wait: removed internal logging · e59b36b1
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
e59b36b1
tools/lxc_usernsexec: removed internal logging · c110f1a5
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
c110f1a5
tools/lxc_unshare: removed internal logging · 39636ab9
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
39636ab9
tools/lxc_unfreeze: removed internal logging · ef551213
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
ef551213
tools/lxc_top: removed internal logging · c56e9243
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
c56e9243
tools/lxc_stop: removed internal logging · cbcc4694
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
cbcc4694

tools/lxc_start: removed internal logging · 271aeb56

authored Nov 28, 2017

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

271aeb56

tools/lxc_snapshot: removed internal logging · 59858f43
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
59858f43
tools/lxc_monitor: removed internal logging · 0c7fd1c5
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
0c7fd1c5
tools/lxc_copy: remove internal logging · 8ec03fc6
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
8ec03fc6
tools/lxc_ls: remove internal logging · 43172d1c
AustinReichert authored Nov 28, 2017
```
Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>
```
43172d1c

btrfs: fix btrfs_snapshot() · 1ec1b962

authored Nov 28, 2017

Closes #1956.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

1ec1b962

storage: constify where possible · ebe5c8c5

authored Nov 28, 2017

This was made necessary by changes to the overlay driver.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

ebe5c8c5

storage: remove unused declaration · 33c84116

authored Nov 28, 2017

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

33c84116

storage: make storage_copy() cleaner · 552e2dd1

authored Nov 28, 2017

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

552e2dd1

lxccontainer: various container creation fixes · b18a1c92

authored Nov 28, 2017

This is beneficial for LXD as well.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

b18a1c92

storage: make storage_init() smart and simplify · 996d16c3

authored Nov 28, 2017

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

996d16c3