Signed-off-by: Pierre LALET <pierre.lalet@cea.fr>

Signed-off-by: Pierre LALET <pierre.lalet@cea.fr>

- Backing Store types are hard-coded (Not sure how to get programmatically)
- Closes #1236
Signed-off-by: Abbas Ally <abbasally5@yahoo.com>

I followed the [changelog of Slackware-current]<http://www.slackware.com/changelog/>,
and found that Slackware-current split hostname utility from util-linux package in Nov 17 2017.
So I add the new package to the template.
Signed-off-by: Chia-Chun Hsu <a12321aabb@gmail.com>

Closes https://github.com/lxc/lxc/issues/1928Signed-off-by: i.Dark_Templar <darktemplar@dark-templar-archives.net>

Change conf.c to export function write_id_mapping, which will now be
called inside main function of lxc_unshare.c.

This is required because setuid syscalls only permits a new userns to
set a new uid if the uid of parameter is mapped inside the ns using
uid_map file[1]. So, just after the clone invocation, map the uid passed as
parameter into the newly created user namespace, and put the current uid
as the ID-outside-ns. After the mapping is done, setuid call succeeds.

Closes: #494

[1] https://elixir.free-electrons.com/linux/latest/source/kernel/user_namespace.c#L286Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

This is beneficial for LXD as well.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Signed-off-by: AustinReichert <austinskyreichert@utexas.edu>

Move duplicated implementatin of sethostname from conf.c and
lxc_unshare.c to utils.h
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Closes: #84
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Signed-off-by: Yifeng Tan <tanyifeng1@huawei.com>
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>

Closes #1946.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: David Negreira David@otherreality.net

Check the test user (lxcunpriv) before calling deluser command,
otherwise it will print unnecessary error message:
/usr/sbin/deluser: The user 'lxcunpriv' does not exist.
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

Signed-off-by: Jonathan Calmels <jcalmels@nvidia.com>

Remove dead state clients from state client list. Consider the following
scenario:

01 start container
02 issue shutdown request
03 state_client_fd is added to lxc_handler
03 container doesn't respond to shutdown request
04 user aborts shutdown request
05 lxc_cmd_fd_cleanup() removes state_client_fd from lxc_mainloop
06 invalid state_client_fd is still recorded in the lxc_handler
07 user issues lxc_cmd_stop() request via SIGKILL
08 container reaches STOPPED state and sends message to state_client_fd
09 state_client_fd number has been reused by lxc_cmd_stop_callback()
10 invalid data gets dumped to lxc_cmd_stop()

Reproducer:
Set an invalid shutdown signal to which the init system does not respond with a
shutdown via lxc.signal.halt e.g. "lxc.signal.halt = SIGUSR1". Then do:

1. start container
    root@conventiont|~
    > lxc-start -n a1

2. try to shutdown container
    root@conventiont|~
    > lxc-stop -n a1

3. abort shutdown
^C

4. SIGKILL the container (lxc.signal.stop = SIGKILL)
    root@conventiont|~
    > lxc-stop -n a1 -k
    lxc-stop: a1: commands.c: lxc_cmd_rsp_recv: 165 File too large - Response data for command "stop" is too long: 12641 bytes > 8192

To not let this happen we remove the state_client_fd from the lxc_handler when
we detect a cleanup event in lxc_cmd_fd_cleanup().
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>