Skip to content

L
lxc
Switch branch/tag
  1. 03 Jul, 2019 9 commits
  3. 02 Jul, 2019 5 commits
  5. 30 Jun, 2019 1 commit
  7. 29 Jun, 2019 1 commit
  9. 28 Jun, 2019 2 commits
  11. 27 Jun, 2019 12 commits
  13. 21 Jun, 2019 1 commit
  15. 20 Jun, 2019 4 commits
  17. 18 Jun, 2019 2 commits
  19. 16 Jun, 2019 1 commit
  21. 15 Jun, 2019 2 commits
    • Fixed file descriptor leak for network namespace · aa0c0e7b
      Rachid Koucha authored 
      In privileged mode, the container startup looses a file descriptor for "handler->nsfd[LX_NS_NET]". At line 1782, we preserve the namespaces file descriptor (in privileged mode, the network namespace is also preserved) :
	for (i = 0; i < LXC_NS_MAX; i++)
		if (handler->ns_on_clone_flags & ns_info[i].clone_flag)
			INFO("Cloned %s", ns_info[i].flag_name);

	if (!lxc_try_preserve_namespaces(handler, handler->ns_on_clone_flags, handler->pid)) {
		ERROR("Failed to preserve cloned namespaces for lxc.hook.stop");
		goto out_delete_net;
	}

Then at line 1830, we preserve one more time the network namespace :
		ret = lxc_try_preserve_ns(handler->pid, "net");
		if (ret < 0) {
			if (ret != -EOPNOTSUPP) {
				SYSERROR("Failed to preserve net namespace");
				goto out_delete_net;
			}
The latter overwrites the file descriptor already stored in handler->nsfd[LXC_NS_NET] at line 1786.

So, this fix checks that the entry is not already filled.
Signed-off-by: 's avatarRachid Koucha <rachid.koucha@gmail.com>
    • Merge pull request #3045 from hallyn/2019-06-13/openssl · 3d43f611
      Serge Hallyn authored 
      [RFC\ Switch from gnutls to openssl for sha1