Commits · f5825bc9226029bfdab1336c026448c48ab31804 · Chen Yisong / lxc

28 May, 2018 3 commits

conf: ensure lxc_delete_tty() does not crash · f5825bc9

authored May 28, 2018

We need to make sure that the ttys are actually initialized otherwise deleting
them is not safe.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

f5825bc9

start: do not init ns_clone_flags to -1 · 79616f3b

authored May 28, 2018

ns_clone_flags is used as a bitmask so initializing it to -1 is a bad idea.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

79616f3b

network: fix socket handle leak · 20b88030
Donghwa Jeong authored May 28, 2018
```
Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>
```
20b88030

26 May, 2018 14 commits
- utils: fix task_blocking_signal() · 6bbfd894
  Christian Brauner authored May 26, 2018
```
Closes #2342.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6bbfd894
- conf: non-functional changes · 9f154bb4
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9f154bb4
- conf: pts -> pty_max · d5865e7e
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d5865e7e
- conf: simplify tty handling · dfb24c15
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  dfb24c15
- conf: reshuffle mount members · e0860629
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e0860629
- conf: make close_all_fds a boolean · 35b6e9e7
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  35b6e9e7
- conf: non-functional changes · 443a29a8
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  443a29a8
- conf: make is_execute a boolean · b635dc4f
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b635dc4f
- conf: non-functional changes · 1aa52fc6
  Christian Brauner authored May 26, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1aa52fc6
- coverity: #1435747 · 0ace0087
  Christian Brauner authored May 26, 2018
```
Dereference before null check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0ace0087
- coverity: #1435803 · 13fae236
  Christian Brauner authored May 26, 2018
```
Unchecked return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  13fae236
- coverity: #1435805 · 02139e29
  Christian Brauner authored May 26, 2018
```
Logically dead code
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  02139e29
- coverity: #1435806 · 22cfc4fa
  Christian Brauner authored May 26, 2018
```
Logically dead code
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  22cfc4fa
- tools: fix lxc-create with global config value II · 918d16b7
  Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  918d16b7
25 May, 2018 11 commits

tools: fix lxc-create with global config value · 5a09d96e
Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
5a09d96e

seccomp: make do_resolve_add_rule() more strict · 460babdb

authored May 25, 2018

Let's error out on syscalls that cannot be resolved or fail to resolve instead
of just warning users.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

460babdb

seccomp: parse_v2_rules() · ab0dd94d
Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ab0dd94d
seccomp: lxc_read_seccomp_config() · 527d15f8
Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
527d15f8

seccomp: error on unrecognized actions · 3b09ea5a

authored May 25, 2018

Be more strict about unrecognized actions. Previously the
parser would happily accept lines with typos like:

  kexec_load errrno 1

(note the extra 'r')
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

3b09ea5a

seccomp: refactor line handling of parse_config · 3ce8c639

authored May 25, 2018

Moving parse_config_v2 to use getline accidentally parsed
the wrong buffer. Since both _v1 and _v2 now use getline it
seems to be simpler to also use getline() for the first line
before entering the version specific parsers and pass along
the pointer and size so they can reuse them.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: 9c3798eb ("seccomp: parse_config_v2()")

3ce8c639

seccomp: re-add action parse error handling · c88d84cb

authored May 25, 2018

This can happen when the 'errno' action can't parse its
supplied number.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: f67c94d0 ("seccomp: parse_v2_rules()")

c88d84cb

seccomp: leak fixup · 0d83285d

authored May 25, 2018

Fix an error case not free()ing the line forgotten during
the move from fgets() on a static buffer to using getline.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: ccf8d128 ("seccomp: parse_config_v1()")

0d83285d

start: log setns() failure · 6e816a91
Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
6e816a91
confile: order architectures · 2c16d4e5
Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
2c16d4e5
lxccontainer: fix fd leaks when sending signals · 1b4872c7
Christian Brauner authored May 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
1b4872c7

24 May, 2018 12 commits
- utils: fix task_blocking_signal() · 42a0468f
  Christian Brauner authored May 24, 2018
```
sscanf() skips whitespace anyway so don't account for tabs in case the file
layout changes.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  42a0468f
- tree-wide: s/sigprocmask/pthread_sigmask()/g · d6dbd268
  Christian Brauner authored May 24, 2018
```
The behavior of sigprocmask() is unspecified in multi-threaded programs. Let's
use pthread_sigmask() instead.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d6dbd268
- seccomp: lxc_read_seccomp_config() · 8f0f76eb
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8f0f76eb
- seccomp: parse_config() · 800f0db5
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  800f0db5
- seccomp: parse_config_v2() · cf6201b4
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cf6201b4
- seccomp: do_resolve_add_rule() · 4a78ed5d
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4a78ed5d
- seccomp: scmp_filter_ctx get_new_ctx() · 9ec37277
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9ec37277
- seccomp: get_hostarch() · cf1bd7e4
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cf1bd7e4
- seccomp: move #ifdefines · f55ef0ba
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f55ef0ba
- seccomp: parse_v2_rules() · 4a9da964
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4a9da964
- seccomp: fix get_seccomp_arg_value() · 24ee9717
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  24ee9717
- seccomp: get_v2_action() · a9034401
  Christian Brauner authored May 24, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  a9034401