Commits · f761d24da62df2b67e18bcb9879d8de29a1ae18d · Chen Yisong / lxc

10 Mar, 2020 11 commits
- cgfsng: use __do_free_string_list all over · f761d24d
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f761d24d
- file_utils: include stdio.h for fmemopen() · e1e08f39
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  e1e08f39
- tests/share_ns: always call pthread_exit() · 1b9aca11
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1b9aca11
- memory_utils: remove unneeded inclusion of mntent.h · 9b53e0b7
  Christian Brauner authored Mar 10, 2020
```
Fixes: Android
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9b53e0b7
- Merge pull request #3281 from brauner/2020-03-10/fixes · 208b3ee0
  Stéphane Graber authored Mar 10, 2020
```
tree-wide: cleanup
```
  208b3ee0
- cgroups: fix memory leak and simplify code · bbba37f7
  Christian Brauner authored Mar 10, 2020
```
Closes #3252.
Reported-by: LiFeng <lifeng68@huawei.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  bbba37f7
- tests/share_ns: bugfixes · dab55f77
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  dab55f77
- conf: cleanup · 55022530
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  55022530
- commands_utils: cleanup · cdd67314
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cdd67314
- commands: cleanup · 6c6497ea
  Christian Brauner authored Mar 10, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6c6497ea
- Merge pull request #3279 from brauner/2020-03-04/improvements · 32a0f033
  Stéphane Graber authored Mar 09, 2020
```
bugfixes
```
  32a0f033
09 Mar, 2020 21 commits

tree-wide: more cleanup macros · b87ee312
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
b87ee312
lxccontainer: increase cleanup macro usage · 768e7ba2
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
768e7ba2
autotools: fix lxc-init build with clang-10 · b816bdde
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
b816bdde
tree-wide: improve logging · 818a57fc
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
818a57fc
tree-wide: make files cloexec whenever possible · 4110345b
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
4110345b
attach: cleanup various helpers · c2af3a15
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
c2af3a15
attach: use logging helpers when handling no new privileges · 02d3b72b
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
02d3b72b
attach: use cleanup macros and logging helpers when fetching seccomp · cca66e06
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
cca66e06
attach: use LXC_INVALID_{G,U}ID macros · a5d657d3
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a5d657d3
attach: use cleanup macros in lxc_attach_getpwshell() · 1b9c9f5b
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
1b9c9f5b
attach: fix fd leak · cf4026f1
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
cf4026f1
attach: cleanup · ffeeed8b
Christian Brauner authored Mar 05, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
ffeeed8b
cgroup2_devices: fix logic error · 874145c1
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
874145c1
commands: remove unused variables · 07e17859
Christian Brauner authored Mar 09, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
07e17859
Merge pull request #3280 from Piscolero/state_client_socket_leak_fix · 61e9751f
Christian Brauner authored Mar 09, 2020
```
commands_utils: fix socket leak when adding state client
```
61e9751f

commands_utils: fix socket leak when adding state client · ebbca852

authored Mar 09, 2020

If lxc_add_state_client() is called with the container already being in the desired state the client fd will never be closed and is leaking. This is due to setting stay_connected in lxc_cmd for LXC_CMD_ADD_STATE_CLIENT. If the desired state isn't already achieved the client fd will later be closed by calling lxc_cmd_fd_cleanup() but in the other case the client configuration isn't added to the handlers
state clients. So the client fd has to be closed explicitely.

This is simply tested by starting container A and calling lxc-wait -n A -s RUNNING.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>

ebbca852

Revert "commands_utils: fix socket leak in when adding state client" · 2b3b8f65
Matthias Hardt authored Mar 09, 2020
```
This reverts commit d7aa5552.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>
```
2b3b8f65
Revert "commands_utils: indicate taking ownership of state_client_fd in" · ee38ab3f
Matthias Hardt authored Mar 09, 2020
```
This reverts commit cd0dc360.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>
```
ee38ab3f
commands_utils: indicate taking ownership of state_client_fd in · cd0dc360
Matthias Hardt authored Mar 09, 2020
```
lxc_add_state_client()
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>
```
cd0dc360

commands_utils: fix socket leak in when adding state client · d7aa5552

authored Mar 09, 2020

If lxc_add_state_client() is called with the container already being in
the desired state the client fd will never be closed and is leaking.
This due to setting stay_connected in lxc_cmd for
LXC_CMD_ADD_STATE_CLIENT. If the desired state isn't already achieved
the client fd will later be closed by calling lxc_cmd_fd_cleanup() but
in the other case the client configuration isn't added to the handlers
state clients. So the client fd has to be closed explicitely.

This is simply tested by starting container A and calling lxc-wait -n A
-s RUNNING.
Signed-off-by: Matthias Hardt <matthias.hardt@gmail.com>

d7aa5552

af_unix: cleanup · 2fb94e95
Christian Brauner authored Mar 04, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
2fb94e95

08 Mar, 2020 4 commits

Merge pull request #3278 from tomponline/tp-proxy-sleep · d31059ef
Christian Brauner authored Mar 08, 2020
```
network: Adds short sleep between veth setup and neighbour proxy add
```
d31059ef
Merge pull request #3277 from tomponline/tp-router-netlink · e901a7a1
Christian Brauner authored Mar 08, 2020
```
network: Uses netlink for IP neighbour proxy management
```
e901a7a1

network: Adds short sleep between veth setup and neighbour proxy add · 954e36b4

authored Mar 08, 2020

There is an intermittent issue, experienced on at least Ubuntu 18.04 (5.3.0-40-generic) and Alpine 3.11 (5.4.12-1-virt) when using the router network interface type that causes the IP proxy neighbour entries on the host side of the veth pair to not be created.

The `ip neigh add proxy` command returns without an error, however by the time the network up hook has started the IP neighbour proxy entries are no longer there (if they ever were).

I've also tested this using netlink rather than the ip command to add and both are equally affected.

Adding a short sleep between setting up the veth pair and adding the proxy entries appears to fix it.
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

954e36b4

network: Uses netlink for IP neighbour proxy management · 5fe147e9

authored Mar 08, 2020

Removes need for ip command when managing IP neighbour proxies.
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

5fe147e9

05 Mar, 2020 4 commits
- Merge pull request #3275 from brauner/2020-03-05/api_extension · 1b3e4274
  Stéphane Graber authored Mar 05, 2020
```
utils: only move_fd() when fdopen() has been successful
```
  1b3e4274
- utils: only move_fd() when fdopen() has been successful · 92bdc593
  Christian Brauner authored Mar 05, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  92bdc593
- Merge pull request #3274 from brauner/2020-03-05/api_extension · 4f31df93
  Stéphane Graber authored Mar 05, 2020
```
fixes
```
  4f31df93
- api-extensions: document cgroup2_devices and cgroup2 api extensions · c60ee0a9
  Christian Brauner authored Mar 05, 2020
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  c60ee0a9