- 15 Jul, 2009 2 commits
-
-
Daniel Lezcano authored
Add a helper to dup the lxc_arguments, so the code making the copy of the arguments will be more clear. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Make some cleanup around the parameters of lxc-init. The option mount procfs is not needed as we want to do that all the time. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 13 Jul, 2009 2 commits
-
-
Daniel Lezcano authored
This patch makes lxc to detect a specific cgroup dedicated to lxc which is mounted with the lxc name. That allows to mount different cgroup in different places with different options (aka subsystems) and assign one to be used by lxc. If no such mount point is found, the first cgroup mount point is used. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Michel Normand authored
Before this patch a container was able to be started without mounted cgroup. (only a warning was logged) But the lxc-ps is using the /proc/<pid>/cgroup to identify the lxc container in which pid is running. So to be consistent between all lxc command I force an error if cgroup is not mounted at time of lxc-execute or lxc-start. Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 10 Jul, 2009 3 commits
-
-
Daniel Lezcano authored
There are several cases: * we run the lxc-create as root, the @path@/var/lib/lxc will be created * we run the lxc-create as non-root, the creation of the directory will fail with "permission denied", so we should call lxc-setcap before * we run lxc-setcap (always as root), we create the directory and set the permission for everyone. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Don't create the directory when we install the lxc package. This is handled by lxc-create. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Ryousei Takano authored
Hi Daniel and all, I am trying to run LXC on the CentOS 5.3 and the Linux kernel 2.6.30. I found a problem with running the rpmbuild command. The error message is shown below: $ rpmbuild -bb lxc.spec <snip> /usr/bin/install -c 'lxc-setcap' '/var/tmp/lxc-0.6.2-build/usr/bin/lxc-setcap' /usr/bin/install -c 'lxc-version' '/var/tmp/lxc-0.6.2-build/usr/bin/lxc-version' mkdir: cannot create directory `/var/lib/lxc': Permission denied make[3]: *** [install-exec-local] Error 1 make[3]: Leaving directory `/home/ryousei/rpm/BUILD/lxc-0.6.2/src/lxc' make[2]: *** [install-am] Error 2 make[2]: Leaving directory `/home/ryousei/rpm/BUILD/lxc-0.6.2/src/lxc' make[1]: *** [install-recursive] Error 1 make[1]: Leaving directory `/home/ryousei/rpm/BUILD/lxc-0.6.2/src' make: *** [install-recursive] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.26914 (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.26914 (%install) This patch removes 'install-exec-local' rule in Makefile. It is not necessary, and it causes rpmbuild failure on the CentOS 5.3. Signed-off-by:Ryousei Takano <takano-ryousei@aist.go.jp> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 07 Jul, 2009 3 commits
-
-
Daniel Lezcano authored
This code is no longer used, remove it. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Make use of the lxc_clone function and do no longer use the fork_ns function. The lxc-unshare utility has been changed to always do a fork. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
This patch replaces the clone syscall by the glibc clone making the code not tied with the syscalls number declaration. The unshare syscall has been removed as it is not interesting. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 03 Jul, 2009 1 commit
-
-
Daniel Lezcano authored
This file may be without any permission Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 02 Jul, 2009 6 commits
-
-
Filippo Giunchedi authored
Point users in documentation to also enable POSIX capability for dropping CAP_BOOT. Signed-off-by:
Filippo Giunchedi <filippo@esaurito.net> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Filippo Giunchedi authored
This might result in more evident lack of support for POSIX capabilities enabled as pointed in documentation Signed-off-by:
Filippo Giunchedi <filippo@esaurito.net> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Filippo Giunchedi authored
Probably a mention to libcap-2 is worth keeping, though it might be clearer to point to setcap binary directly. Signed-off-by:
Filippo Giunchedi <filippo@esaurito.net> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Filippo Giunchedi authored
Rationale: some distributions don't include /sbin in PATH for regular users, thus setcap might not be found during configure Signed-off-by:
Filippo Giunchedi <filippo@esaurito.net> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Filippo Giunchedi authored
These options appear in 2.6.29 in different locations, update the sgml accordingly Signed-off-by:
Filippo Giunchedi <filippo@esaurito.net> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
christophe.quintard@fr.ibm.com authored
I think this explanation is better. Signed-off-by:
Christophe Quintard <christophe.quintard@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 01 Jul, 2009 2 commits
-
-
Michel Normand authored
this is the man page update following the previous git commit 7cbfc4e4Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Add missing include stdlib.h Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 25 Jun, 2009 5 commits
-
-
Michel Normand authored
lxc-execute has to return the exit code of it's child not others as today's code would return the exit code of the last child. We need to track the first process we launched and store its exit status when it exits. In order to avoid to detect the exit of this pid several time if the pids number wrap, we put an extra flag saying the process group is orhpan. Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Michel Normand authored
Implement the lxc-ps script with perl script. Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Michel Normand authored
I did this one change by reading the code but did not tried to run it. Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Michel Normand authored
the lxc_unlink_nsgroup may fail on ppc where the stack is not zeroed by default and because the readlink function do not add trailing null character. Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Michel Normand authored
Update the checkpoint and restart regarding the statefile parameter. Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 24 Jun, 2009 1 commit
-
-
Matty authored
Howdy, I was playing around with LXC containers this past weekend, and noticed a couple of issues with the lxc-fedora script: #1: Line 96 should be ${ROOTFS}/etc/sysconfig/network instead of ${ROOTFS}/sysconfig/network #2 Line 249 contains a reference to $PKG, which isn't used in the program. I adjusted the variable to point to the correct package, and use this in the calls to yumdownloader: PKG="${DISTRO}-release.noarch.rpm" ..... yumdownloader --destdir="${CACHE}/partial" "${PKG}" #3 The $CACHE/partial path is escaped unnecessarily: RPM="rpm --root \"${CACHE}/partial\"" #4 The program assumes yumdownloader will work, which isn't always the case. I added an if statement to check the return code: echo "Downloading distribution release file ${PKG}" yumdownloader --destdir="${CACHE}/partial" "${PKG}" RESULT=$? if [ "${RESULT}" != "0" ]; then echo "Enable to download the distribution release file" exit 1 fi #5 The package name passed to yumdownloader is incorrect: yumdownloader --destdir="${CACHE}/partial" "${DISTRO}-release.noarch.rpm" On Fedora 10 and 11, this evaluates to: fedora-release.noarch.rpm When we need it to evaluate to: fedora-{RELEASE_VER}.release.noarch This is fixed in the PKG variable listed above. A patch that addresses these issues is attached. Thanks, - Ryan Signed-off-by:Matty <matty91@gmail.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 12 Jun, 2009 2 commits
-
-
Daniel Lezcano authored
The current code implies we have to define a utsname in order to unshare it. This problematic in case of system container because we want them to set their hostname. As the utsname namespace is a COW, we can safely unshare it in all the cases. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
The capability.h header is broken on fedora 11. The workaround is to include <sys/types.h> before <sys/capability.h>. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 10 Jun, 2009 5 commits
-
-
Daniel Lezcano authored
Stupid me, we don't want to add a dependency to an external tool as the library has to be standalone. Just let lxc to define a .pc file, so the upper layer will find the needed informations to use it. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Remove this file as it is not used. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Rename lxc-config to lxc-version in order to avoid the confusion with what looks like a container configuration tool. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
As we have the correct informations with pkg-config we can write a script which will collect the informations and we get rid of the C program. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Add the pkg-config information for lxc. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 07 Jun, 2009 6 commits
-
-
Daniel Lezcano authored
Don't clean up the sgml which are generated by configure, otherwise at the next make, the documentation generation will complain about missing files. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
When we daemonize the container and we specify the log file, the container will use the log file to write the console output. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
If needed the container can be launched in background with a specific option -d. That will make mute the container, the logs can help to check what went wrong. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Daniel Lezcano authored
Save the tty configuration before calling lxc_start and restore it right after it has been changed. Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Filippo Giunchedi authored
Hi, as per subject, this ignores binaries generated in test/ Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
Filippo Giunchedi authored
Hi, I've been playing with lxc, though with --enable-test the test/ directory doesn't compile, the following patch ought to fix this. I've not tested tests throughly but seems straightforward enough. Update the API usage in test/ as to make tests compile Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 29 May, 2009 1 commit
-
-
Daniel Lezcano authored
Signed-off-by:Daniel Lezcano <dlezcano@fr.ibm.com>
-
- 28 May, 2009 1 commit
-
-
Michel Normand authored
the common options of lxc commands are now described in one file "common_options.sgml.in" Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-