Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tools: fix container use-after-free

Fields daemonize and error_num were being called after the
lxc_container_put.
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

doc: Remove aufs in Japanese man pages

* and tweak English lxc-copy(1)
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

tree-wide: remove aufs storage driver

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

We've announced quite a while back and printed out errors and warning everytime
someone used the aufs driver.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

fix handler use-after-free

The problem here is that __lxc_start frees the handler, so any use
afterwards is invalid. Since we don't have access to the actual struct
lxc_container object in __lxc_start, let's pass a pointer to error_num in
so it can be returned.

Unfortunately, I'm a little too paranoid to change the return type of
lxc_start, since it returns failure if some of the cleanup fails, which
may be useful in some cases. So let's keep this out of band.

Closes #2218
Closes #2219
Reported-by: Felix Abecassis <fabecassis@nvidia.com>
Signed-off-by: Tycho Andersen <tycho@tycho.ws>

conf: do not run the "mount" hooks twice

Regression introduced by 8353b4c9Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

conf: fix clang warning when building w/o libcap

when compiling lxc with clang-5.0 parse_cap()'s main loop will produce a
warning about a tautological comparision (#2215).

By moving the result of computation into a variable (end) this is no
longer a constant expression. clang-5.0 does not do dataflow analysis at
this point, so it is, to quote someone from #llvm, "morally equivalent"
to casting `(int)i`.

in addition, we also clean up the #if HAVE_LIBCAP to no longer need
its #else branch!
Signed-off-by: Igor Galić <igor.galic@automatic-server.com>

tools: fix usage of boolean function set_config_item

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

Revert "cgroups: don't escape if we're not real root"

This reverts commit 8d961e28.

Unfortunately I don't believe the check is correct in the general case.
Signed-off-by: Serge Hallyn <shallyn@cisco.com>

cgroups: don't escape if we're not real root

If we're host unpriv but root in our userns, we can't really escape
cgroups. Let's switch the cgroup escape test to reflect this.
Signed-off-by: Tycho Andersen <tycho@tycho.ws>

usernsexec: init log fd

lxc-usernsexec uses some functions (e.g. lxc_map_ids()), which are part of
the lxc library and thus use the WARN etc. macros to emit log messages.
However, it doesn't initialize the log in any way, so these messages go
into the ether.

lxc-usernsexec currently has no log parameters, so let's just log these to
stderr. Someone can do something fancier later if they want.
Signed-off-by: Tycho Andersen <tycho@tycho.ws>

tools: Include config.h in tool_utils.c

Since we do not include config.h, personality is not set. This is fix
it. See issue #2208.
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Add a workaround for a build issue with old versions of libcap

Fixes: #2178
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>

CODING_STYLE: update

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

doc: Add lxc.console.size and remove lxc.console.buffer.logfile in Japanese man page

Update for commit 861813e5 and 23e0d9af for lxc.container.conf(5)
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

start: handle kernels without setns support 

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Closes #1390.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>