Commits · lxc-3.0.2 · Chen Yisong / lxc

16 Aug, 2018 11 commits

Release LXC 3.0.2 · 56fb4efa
Stéphane Graber authored Aug 16, 2018
```
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
56fb4efa
lxc-usernsexec: cleanup and bugfixes · a5a455fe
Christian Brauner authored Aug 16, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a5a455fe

authored Aug 16, 2018

Add a thread-safe and uniform way to retrieve errno values in programs that are
shipped as part of LXC but are not expected to have access to the logging
system.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

9a926cbb

log: add CMD_SYSERROR() · 37b9abb1

authored Aug 16, 2018

Add a thread-safe and uniform way to retrieve errno values in programs that are
shipped as part of LXC but are not expected to have access to the logging
system.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

37b9abb1

cmd: Move assignment out of if statement · ee75dca2

authored Aug 16, 2018

checkpatch.pl emits error

    ERROR: do not use assignment in if condition

Move assignment out of if statement.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

ee75dca2

cmd: Fix whitespace ERRORS · 1ccfb5cd

authored Aug 16, 2018

checkpatch.pl emits a bunch of warnings about various whitespace
issues.  Fix all these as a single patch since they are all whitespace
only changes.

Fix whitespace issues found by checkpatch.pl
Signed-off-by: Tobin C. Harding <me@tobin.cc>

1ccfb5cd

cmd: Do not initialise statics to 0 · 2d4beae5

authored Aug 16, 2018

checkpatch.pl emits error

    ERROR: do not initialise statics to 0

Do not initialise statics to 0.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

2d4beae5

cmd: Correctly indent switch statement · d3d13097

authored Aug 16, 2018

checkpatch.pl emits error

    ERROR: do not use assignment in if condition

Correctly indent switch statement.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

d3d13097

usernsexec: Make err out vebose for unshare error · fbc67eba

authored Aug 16, 2018

Currently if lxc-usernsexec is run on a kernel without user namespaces
enabled the error message is

	unshare: Invalid argument
	read pipe: Success

This error message 'Invalid argument' does not point at the root cause
of the error.  We can help the user out by giving a more detailed error
message and also not using perror() if errno==0.

Improve error message by
 - Printing unshare flags
 - Printing suggested cause of failure (user namespace not enabled)
 - Print error message with fprintf() if errno==0 (EOF)
Signed-off-by: Tobin C. Harding <me@tobin.cc>

fbc67eba

doc: Fix minor grammatical errors · fcacfc5b

authored Aug 16, 2018

Current we have a few minor grammatical errors in the documentation for
lxc container configuration.

Fix minor grammatical errors.
Signed-off-by: Tobin C. Harding <me@tobin.cc>

fcacfc5b

state: s/sleep()/nanosleep()/ · e6516582

authored Aug 16, 2018

sleep() is not thread-safe but nanosleep() is. Since no resources are allocated
in lxc_wait() it is safe to call nanosleep() without cancellation handlers.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

e6516582

15 Aug, 2018 3 commits
- lxccontainer: minor fixes · 4cb8ca34
  Christian Brauner authored Aug 16, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4cb8ca34
- lxclock: improve file locking · cf5792ba
  Christian Brauner authored Aug 15, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cf5792ba
- lxccontainer: improve file locking · cbe4e254
  Christian Brauner authored Aug 15, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  cbe4e254
14 Aug, 2018 4 commits

lxccontainer: fix F_OFD_GETLK checks · b0f8ec9b

authored Aug 14, 2018

When we check whether an open file description lock has been taken on a file we
need to set the l_pid field to 0 otherwise the kernel will send back EINVAL.
Additionally, the kernel will not do pid translation and simply set the l_pid
value to -1.

Fixes https://discuss.linuxcontainers.org/t/container-deleted-or-stopped-when-lxc-ls-executed-concurrently/2439Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

b0f8ec9b

coverity: #1438392 · 2fc67556

authored Aug 14, 2018

Dereference before null check
Signed-off-by: 2xsec <dh48.jeong@samsung.com>

2fc67556

fix thread safe issue(localtime => localtime_r) · d3bcd794
2xsec authored Aug 13, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
d3bcd794
macro: remove duplicated define · 7a4c56fe
2xsec authored Aug 13, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
7a4c56fe

12 Aug, 2018 22 commits
- netlink: add __netlink_{send,recv,transaction} · fcfb1b3e
  Christian Brauner authored Aug 11, 2018
```
These allow to pass a struct nlmsghdr directly and are used in the higher level
netlink_{send,rcv,transaction}.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  fcfb1b3e
- start: make netnsid allocation failures non-fatal · 5018440b
  Christian Brauner authored Aug 11, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  5018440b
- netns: improve netnsid allocation · 60ce299f
  Christian Brauner authored Aug 11, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  60ce299f
- macro: add NLMSG_ERROR · 0ec7171f
  Christian Brauner authored Aug 11, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  0ec7171f
- fix assignment of signed to bigger unsigned issue · 92cce8ee
  2xsec authored Aug 10, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  92cce8ee
- fix tainted int loop bound issue · 14c1904b
  2xsec authored Aug 10, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  14c1904b
- tests: containertests: fix dereference pointer c · 4e194cee
  2xsec authored Aug 09, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  4e194cee
- network: type fixes lxc_netns_set_nsid() · 1c0bec10
  Christian Brauner authored Aug 09, 2018
```
The kernel expects a __s32 for NETNSA_NSID and a __u32 for NETNSA_FD.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1c0bec10
- netns: vendor NETNSA_* · 6810e31d
  Christian Brauner authored Aug 08, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6810e31d
- travis: add linux-libc-dev · ac9bd624
  Christian Brauner authored Aug 08, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  ac9bd624
- macro: move network macros from utils.h · 4f32911f
  Christian Brauner authored Aug 08, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  4f32911f
- netns: allocate network namespace id · f2e770a1
  Christian Brauner authored Feb 06, 2018
```
Start to allocate a new network namespace id for each container.

Relates to https://github.com/lxc/lxd/issues/4831.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f2e770a1
- MAINTAINERS: add Wolfgang Bumiller · 12c3adb4
  Christian Brauner authored Aug 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  12c3adb4
- CVE 2018-6556: verify netns fd in lxc-user-nic · 9d5053a6
  Christian Brauner authored Jul 25, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9d5053a6
- templates: avoid endless loop · 65f0fc23
  Christian Brauner authored Aug 06, 2018
```
Closes #2512.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  65f0fc23
- coverity: #1438232 · f5c8f252
  2xsec authored Aug 06, 2018
```
Failure to restore non-local value
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  f5c8f252
- pam_cgfs: cleanups · 8b88aa05
  2xsec authored Aug 06, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  8b88aa05
- coverity: #1438231 · e97dfb8c
  2xsec authored Aug 06, 2018
```
Dereference after null check
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  e97dfb8c
- coverity: #1438230 · eae95dc7
  2xsec authored Aug 06, 2018
```
Logically dead code
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  eae95dc7
- coverity: #1438229 · 54a3b3df
  2xsec authored Aug 06, 2018
```
Resource leak
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  54a3b3df
- coverity: #1438233 · a0a2c1a1
  2xsec authored Aug 06, 2018
```
Resource leak
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  a0a2c1a1
- coverity: #1438234 · 1c98a6e7
  2xsec authored Aug 06, 2018
```
Resource leak
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  1c98a6e7