-
make lxc-attach use a pty · 5eacdc3dChristian Brauner authored
So far lxc-attach did not use a pty when attaching to a container. This made it vulnerable to tty input faking via TIOCSTI when switching to a different user. This patch makes lxc-attach use a pty in most cases. The only current exemption is when stdin, stdout, and stderr are not referring to a pty. There are two ways how lxc-attach can receive a pty: 1. get a pty in the container 2. get a pty on the host This patch makes 1. the default and only opts for 2. when 1. fails before giving up. The rationale behind this is as follows: If we create a pty on the host (2.) and pass the fds to the container the container may report "no tty" when the "tty" command is used. This could be irritating for users when they expect that lxc-attach now always tries to use a pty. Hence, option 1. is the default. Signed-off-by:Christian Brauner <christian.brauner@mailbox.org>
5eacdc3d
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| include | Loading commit data... | |
| lua-lxc | Loading commit data... | |
| lxc | Loading commit data... | |
| python-lxc | Loading commit data... | |
| tests | Loading commit data... | |
| Makefile.am | Loading commit data... |