Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • OpenGL
  • compiler
  • Types.h
Find file
BlameHistoryPermalink
  • Sean Risser's avatar
    Don't let shaders negate samplers · 39f0247a
    Sean Risser authored Jun 05, 2019
    Prior to this change, the OpenGL compiler accepted all "non-struct"
    "non-array" types for unary operations (++, --, and -). This ignored
    the existence of sampler objects. If someone tried to negate a
    sampler, then the compiler would tell the assembler to negate a non-
    numerical type.
    
    This change makes it so the GSL compiler only accepts unary operations
    on numerical types (including vectors and matrices).
    
    Also added a unittest that makes sure we gracefully fail to compile
    bad unary operations.
    
    Bug chromium:910883
    
    Change-Id: Ia69056b31664900c3126cab42ecb8603d1a5d7db
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32448Tested-by: 's avatarSean Risser <srisser@google.com>
    Presubmit-Ready: Sean Risser <srisser@google.com>
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    39f0247a
Types.h 16.5 KB
EditWeb IDE
×

Replace Types.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.