Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Vulkan
  • VkCommandPool.cpp
Find file
BlameHistoryPermalink
  • Alexis Hetu's avatar
    Fix CommandPool memory management · fa0140b9
    Alexis Hetu authored Sep 10, 2020
    Ever since vk::destroy calls the object destructor, we can have std
    objects in our vulkan objects, rather than std object pointers, which
    allows us to allocate them using the provided allocator, rather than
    having to use DEVICE_MEMORY.
    
    I'm unsure whether there was an actual memory leak here or if ASAN
    was detecting something that wasn't there, but this cl cleans up std
    object allocation and fixes whatever ASAN was detecting. With this
    change, the fuzzer run now completes without issue.
    
    Bug: chromium:1107112
    Change-Id: Ib78451639131eb518e2bf8d63ba70b930aba2216
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48328
    Presubmit-Ready: Alexis Hétu <sugoi@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarAlexis Hétu <sugoi@google.com>
    Reviewed-by: 's avatarBen Clayton <bclayton@google.com>
    fa0140b9
VkCommandPool.cpp 2.87 KB
EditWeb IDE
×

Replace VkCommandPool.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.