Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Vulkan
  • VkImageView.cpp
Find file
BlameHistoryPermalink
  • Alexis Hetu's avatar
    Obtain ImageView state uniquely from its identifier · 41a476ed
    Alexis Hetu authored Feb 16, 2021
    VkImageView state for sampling routine generation was previously
    obtained from the SampledImageDescriptor structure, which assumes that
    the mapping from the identifier to this state is unique. This assumption
    easily breaks as new members field can be added to the descriptor
    structure, without taking into account that the identifier values should
    be unique for each unique field value.
    
    This change removes the ImageView state members from the descriptor
    structure, and instead we obtain them through the identifier,
    guaranteeing a unique mapping.
    
    Note that currently this state is compacted into the identifier's
    32-bit integer value itself. Should more state be required than what
    fits in 32-bit (like is the case for VkSampler objects), the mapping
    between identifiers and their state should be handled through an actual
    map container.
    
    Bug: b/180511322
    Bug: b/152227757
    Change-Id: I1568eb67df29eb29ddcbbe906a90d236078e3080
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52888Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Commit-Queue: Alexis Hétu <sugoi@google.com>
    41a476ed
VkImageView.cpp 13.1 KB
EditWeb IDE
×

Replace VkImageView.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.