Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • ..
  • Config
  • config.h
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Work around std::is_trivially_copyable issue with MSVC · 2014e7b9
    Nicolas Capens authored Aug 25, 2020
    Microsoft Visual Studio Community 2019 Version 16.7.1 produced the
    following errors:
    
    C2976 'llvm::SmallVectorTemplateBase': too few template argument
    SwiftShader\third_party\llvm-10.0\llvm\include\llvm\ADT\SmallVector.h:315
    
    C2338 inconsistent behavior between llvm:: and std:: implementation of is_trivially_copyable
    SwiftShader\third_party\llvm-10.0\llvm\include\llvm\Support\type_traits.h:181
    
    Not defining LLVM's HAVE_STD_IS_TRIVIALLY_COPYABLE config makes it fall
    back to code which doesn't use std::is_trivially_copyable and avoids the
    issue.
    
    Note this may hide a potentially serious MSVC compiler bug since C2338
    is produced by a static_assert. Without that static assert we may not
    have known about the unexpected std::is_trivially_copyable behavior
    until run-time issues are caused by it.
    
    Bug: swiftshader:153
    Change-Id: I04ab6d8ae725ecab45ac27fd89a37213baa86943
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/47930
    Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    2014e7b9
config.h 10.1 KB
EditWeb IDE
×

Replace config.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.