Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • third_party
  • subzero
  • src
  • IceInst.h
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Unify load/store operand accessors · 673a7fe5
    Nicolas Capens authored Feb 05, 2021
    Load and store instructions, as well as intrinsics which access memory,
    can now shared the same methods for accessing the memory address and
    data operands.
    
    Note that while this change introduces the potential for non-load/store
    instructions to have their operands accessed through getLoadAddress(),
    getStoreAddress(), or getData(), that risk isn't any greater than using
    the wrong getSrc() index, and would stick out as a mistake much more
    clearly. The advantage this change brings is that we no longer have to
    remember where the address and data operands are stored in sub-vector
    load/store intrinsics. In addition, there are no more overly verbose
    casts, and their cost is eliminated.
    
    Bug: b/179497998
    Change-Id: I0d9208555e00b0d3053f7d3baca241fef2b8cbeb
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52531
    Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    673a7fe5
IceInst.h 44.8 KB
EditWeb IDE
×

Replace IceInst.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.