Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Pipeline
  • SpirvShaderImage.cpp
Find file
BlameHistoryPermalink
  • Alexis Hetu's avatar
    Also use out of bound detection for image stores · 08afdde7
    Alexis Hetu authored May 06, 2020
    Followup to:
    https://swiftshader-review.googlesource.com/c/SwiftShader/+/43950
    
    Fixes dEQP.KHR_GLES31/core_compute_shader_copyimage.
    This dEQP test was passing by chance, because load and store
    were paired properly together, being equally incorrect with
    regards to the OpenGL ES specs, which mentions:
    
    GLES 3.1 spec, section 8.22:
    If the individual texel identified for an image load or store
    operation doesn’t exist, the access is treated as invalid.
    Invalid image loads will return a vector where the value of
    R, G, and B components is 0 and the value of the A component
    is undefined. Invalid image stores will have no effect.
    
    Bug: b/150464740
    Change-Id: I5aa508ed7f08e234387478d3a6faee958ca9dd97
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44868
    Presubmit-Ready: Alexis Hétu <sugoi@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarAlexis Hétu <sugoi@google.com>
    08afdde7
SpirvShaderImage.cpp 39.8 KB
EditWeb IDE
×

Replace SpirvShaderImage.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.