Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Vulkan
  • VkShaderModule.cpp
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Validate the SPIR-V code in debug builds · 45510ad8
    Nicolas Capens authored Jun 04, 2020
    https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkShaderModuleCreateInfo.html
    states that the "code must adhere to the validation rules described by
    the Validation Rules within a Module section of the SPIR-V Environment
    appendix"
    
    This makes it the application's responsibility to only pass valid SPIR-V
    code to vkCreateShaderModule. However, improperly validated code
    may cause bugs which are hard to root cause, so validate in our
    implementation as well in debug builds. This can also help with fuzzing
    efforts.
    
    Bug: b/158228522
    Change-Id: Ib4f41fa70a021fb902e1f8504005b87c92286942
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45569Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    45510ad8
VkShaderModule.cpp 1.57 KB
EditWeb IDE
×

Replace VkShaderModule.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.