Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Reactor
  • Optimizer.cpp
Find file
BlameHistoryPermalink
  • Antonio Maiorano's avatar
    Subzero: fix regression in Optimizer · 5ff1de53
    Antonio Maiorano authored Mar 03, 2020
    Regression was introduced in
    https://swiftshader-review.googlesource.com/c/SwiftShader/+/41269
    
    When detecting and removing intermediate stores, if the storeValue is a
    constant, we skip it; however, we must make sure to set unmatchedLoads
    to true, or the optimizer will incorrectly eliminate the skipped store
    on a later iteration.
    
    This bug lead to incorrect generated code, which failed certain deqp-vk
    tests, e.g. dEQP-VK.clipping.user_defined.clip_cull_distance.vert.2_6
    
    Bug: b/148272103
    Change-Id: I024d75decdc4f1d13e7f82cade50f8be09d68f3e
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41888Tested-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    5ff1de53
Optimizer.cpp 17.9 KB
EditWeb IDE
×

Replace Optimizer.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.