Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Vulkan
  • VkPipelineCache.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    PipelineCache: Handle nullptr mismatch of specialization info. · 416d3745
    Jamie Madill authored Feb 27, 2020
    It's valid in Vulkan for a shader to have specialization constants
    and the pipeline to be lacking specialization constant data. This
    could lead to a key match between the two even though there should
    be a different shader payload. From the spec:
    
    > It is legal for a SPIR-V module with specializations to be
    > compiled into a pipeline where no specialization info was provided.
    > SPIR-V specialization constants contain default values such that
    > if a specialization is not provided.
    
    Fix this by adding in the required checks. Should not affect perf.
    
    Bug: b/150449637
    Bug: angleproject:4426
    Change-Id: I5f384420bdc1f03a36852db0b20393ae56452b62
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41728Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Presubmit: Jamie Madill <jmadill@chromium.org>
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    416d3745
VkPipelineCache.cpp 7.25 KB
EditWeb IDE
×

Replace VkPipelineCache.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.