Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Main
  • FrameBufferX11.cpp
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Remove X11 window validation. · 8fb6f6a1
    Nicolas Capens authored Jul 13, 2018
    Despite being a 'client resource', the window can become invalid due to
    events outside of the client code's control, which causes
    XGetWindowAttributes to fail because it retrieves servers-side data
    that is no longer available. Hence it is something we should expect to
    see happen, and not (always) an indication of a bug that needs fixing.
    Also, we should be able to safely continue with an invalid window.
    
    At this point it's up to the client code to catch the X error and
    handle it appropriately. The EGL spec does not indicate that it should
    catch it instead and generate an error (eglSwapBuffers can generate
    EGL_CONTEXT_LOST but that's reserved for power management events).
    
    Bug chromium:861882
    Bug chromium:824522
    
    Change-Id: I78a364516b9466f652c94de68553369935590bde
    Reviewed-on: https://swiftshader-review.googlesource.com/19868Reviewed-by: 's avatarAntoine Labour <piman@chromium.org>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    8fb6f6a1
FrameBufferX11.cpp 4.71 KB
EditWeb IDE
×

Replace FrameBufferX11.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.