Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • OpenGL
  • compiler
  • ParseHelper.cpp
Find file
BlameHistoryPermalink
  • Sean Risser's avatar
    Optimize "max(t, t)" to fold into just "t" · a9dc7707
    Sean Risser authored Sep 26, 2019
    This masks a crash related to nested, unconditional continue statements.
    Those constructs are known to be buggy, but we have elected to not fix
    them at this point in time because the SWANGLE project will deprecate
    all of Swiftshader's GLES backend.
    
    It's unlikely that the remaining bug will effect many end-users as it
    relies on bizarre control flow.
    
    For logging purposes here is the shader code that reproduces an infinite
    loop:
    
        void foo() { }
    
        void main() {
    	for (int i = 0; i < 4; i++) {
    	    continue;
    	    for (int k = 0; k < 4; k++)
    		continue;
    	    foo();
    	}
        }
    
    I'm not adding this as a unit test since we aren't fixing our compiler.
    
    Bug chromium:997283
    
    Change-Id: Id31d70c4cd70a16fd20b7ebed18a82d5f8a705ba
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36708Tested-by: 's avatarSean Risser <srisser@google.com>
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    a9dc7707
ParseHelper.cpp 107 KB
EditWeb IDE
×

Replace ParseHelper.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.