Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • OpenGL
  • libGLESv2
  • libGLESv2.lds
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Remove typeinfo from GLES exported symbols · c4bbd378
    Nicolas Capens authored May 04, 2020
    This typeinfo was added for UBSan failures reported in crbug.com/737384,
    but it didn't address other 'Incorrect-function-pointer-type' failures
    for crbug.com/746914. We've suppressed sanitization for these functions
    with the NO_SANITIZE_FUNCTION macro, refactored interfaces used across
    library boundaries into purely abstract ones for crbug.com/732667, and
    use '-mllvm -asan-use-private-alias=1' to address b/128551743.
    
    It's unclear whether this typeinfo still serves ay purpose We shouldn't
    have to export typeinfo for objects used only inside the shared library,
    to avoid ODR violations.
    
    Remove it entirely for now. If this causes a regression and we still
    have to export any typeinfo, we should do so more selectively. For
    example to only export typeinfo for objects in the egl namespace:
    _ZTS*egl*;
    _ZTI*egl*;
    Alternatively, or in addition, we can try using
    '-mllvm -asan-use-private-alias=1' for more build systems.
    
    Bug: b/155441530
    Change-Id: Ia966c40dfe45817f356d11725910afef1bb94d6e
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44688
    Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    c4bbd378
libGLESv2.lds 5.84 KB
EditWeb IDE
×

Replace libGLESv2.lds

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.