Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Shader
  • PixelRoutine.hpp
Find file
BlameHistoryPermalink
  • Sean Risser's avatar
    Fix buffer overflow on Mac · 29364a05
    Sean Risser authored May 28, 2019
    For OpenGL on Mac, Swiftshader renders directly to the IOSurface given
    to us by the OS. This surface is not necessarily vertically padded so
    its height is a multiple of 2. Since we render 4 pixels at a time in a
    quad, the bottom 2 pixels may not be written to legal memory if the
    height of the target surface is an odd number.
    
    This change prevents Swiftshader from rendering quads on Mac if doing so
    would overflow the buffer.
    
    Bug: chromium:944796
    Bug: angleproject:2764
    
    Change-Id: I08bec895980b42f99b8a4434969edcaf7d331284
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32030
    Presubmit-Ready: Sean Risser <srisser@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarSean Risser <srisser@google.com>
    29364a05
PixelRoutine.hpp 4.05 KB
EditWeb IDE
×

Replace PixelRoutine.hpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.