Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Vulkan
  • Debug
  • Value.cpp
Find file
BlameHistoryPermalink
  • Ben Clayton's avatar
    Vulkan/Debug: Overhaul Values / Variables · ce1584d1
    Ben Clayton authored Sep 25, 2020
    `Value` had a number of methods that were never used (like `set()`), so just remove them.
    Remove `Type`, this was also unused, and was unncessarily complex to maintain.
    
    Add `Variables` interface that allows other composite value implementations that are not `VariableContainer`.
    
    Break the inheritance of `VariableContainer` from `Value`, as this forces pointer casting and doesn't work with the `Variables` interface.
    
    Add `Struct` which is an implementation of `Value` that implements the new `children()` method to return the provided `Variables`.
    
    Sets the groundwork for the overhauled debugger implementation.
    
    Note: The changes to `SpirvShaderDebugger.cpp` are a least-effort set of changes to make things compile.
    A significant amount of this file (along with these changes) will be reimplemented in a followup change.
    
    Bug: b/145351270
    Change-Id: Ic3a641a246737b1f82c786fa8c1ec75700b2a71a
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48693
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarBen Clayton <bclayton@google.com>
    Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    ce1584d1
Value.cpp 1.07 KB
EditWeb IDE
×

Replace Value.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.