Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • tests
  • GLESUnitTests
  • unittests.cpp
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Fix register assignment for constant arrays · ce08265b
    Nicolas Capens authored Sep 08, 2020
    Constant arrays are allocated in the same 'register file' as the one
    for per-program uniforms, to support dynamic indexing. While we had
    a special case for that in OutputASM::registerType(), in registerIndex()
    we were actually allocating them in the temporaries register file. This
    led to assigning the same register index range twice, leading to
    overwriting the per-program uniforms with constant array data in the
    shader.
    
    Bug: b/168060171
    Change-Id: If42944d186ed1c1328a8d477edca4662aa1e8e54
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48248
    Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
    ce08265b
unittests.cpp 80.9 KB
EditWeb IDE
×

Replace unittests.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.