Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • ..
  • Config
  • abi-breaking.h
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Set LLVM_ENABLE_ABI_BREAKING_CHECKS for Debug builds only · 59eb5dd0
    Nicolas Capens authored Nov 03, 2020
    LLVM_ENABLE_ABI_BREAKING_CHECKS was disabled everywhere except for
    Fuchsia. It triggered llvm::Error::assertIsChecked() in the new ORCv2
    code because we're supposed to check Expected<> didn't return an error
    by casting it to a bool, which we only do in Debug builds.
    
    Since this option costs performance in Release builds and we don't want
    to abort on errors (especially benign ones), it should only be enable
    for Debug builds. This is also the default behavior for standalone
    builds of LLVM:
    https://llvm.org/docs/ProgrammersManual.html#abi-breaking-checks
    
    Bug: b/171236524
    Bug: chromium:1140854
    Change-Id: If886fe9ef61d0f5392949d34a63ed3d7de7aa916
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/49908Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    59eb5dd0
abi-breaking.h 2.06 KB
EditWeb IDE
×

Replace abi-breaking.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.