Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • third_party
  • llvm-subzero
  • lib
  • Support
  • regcomp.c
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Explicitly compile with warnings-as-errors · 8c13b2f0
    Nicolas Capens authored Mar 06, 2020
    This is a partial revert of https://swiftshader-review.googlesource.com/c/SwiftShader/+/40788
    where .c files were renamed to .cpp to avoid a warning treated as error:
    command line option ‘-fno-operator-names’ is valid for C++/ObjC++ but not for C [-Werror]
    This appears to have caused macOS linker issues: chromium:1059196
    
    Instead, explicitly add the flag to compile with warnings-as-errors
    (when enabled) for code that is actively maintained by us, and make
    Subzero's legacy LLVM dependencies a separate library compiled without
    warnings-as-errors.
    
    Also revert CMakeSettings.json changes that were inadvertently committed.
    
    Bug: b/141361933
    Bug: chromium:1059196
    Change-Id: I27dd57d954a413a710613b0bfa2e69bd5242853a
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41968Reviewed-by: 's avatarMarc-Antoine Desroches <madesroches@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    8c13b2f0
regcomp.c 36.2 KB
EditWeb IDE
×

Replace regcomp.c

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.