Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • third_party
  • subzero
  • src
  • IceOperand.h
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Eliminate code randomization support from Subzero · 6649bd02
    Nicolas Capens authored Feb 11, 2021
    SwiftShader has no use for this since shader execution with robustness
    features enabled can not access memory outside of the graphics
    resources. For Chromium it also runs in the GPU process, which isolates
    it from browser-wide and even tab renderer data and code, and also has
    its own sandboxing.
    
    If we ever do need randomization to prevent attacks, and project Bunker
    doesn't provide the needed site isolation, it should be implemented
    either at the Reactor level or as separate transformation passes where
    possible.
    
    While previously this feature was already disabled, there might have
    been inadvertent randomization which could explain our test time
    variability. It may also improve code generation performance a bit to
    not have this code around any more.
    
    Bug: b/179832693
    Change-Id: If1ccb54981edb61f443dd5949c56b75bab07c7c2
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52808
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
    Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    6649bd02
IceOperand.h 41 KB
EditWeb IDE
×

Replace IceOperand.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.