Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Pipeline
  • ComputeProgram.hpp
Find file
BlameHistoryPermalink
  • Ben Clayton's avatar
    ComputeProgram: Remove data field to fix race. · 518f4384
    Ben Clayton authored Jun 10, 2019
    data is the 0th argument to the coroutine.
    There's no good reason why this was stored as a field when all other arguments were fetched in ComputeProgram::emit().
    
    Having this as a field caused a data race in the rr::Variable materializing, as the destructor of this field was called outside the reactor mutex.
    
    Test: dEQP-VK.synchronization.internally_synchronized_objects.pipeline_cache_compute
    Bug: b/133127573
    Change-Id: I44545b71714fdebd8f1150bf7d6325f7d4d4d3eb
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32569
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Tested-by: 's avatarBen Clayton <bclayton@google.com>
    Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
    518f4384
ComputeProgram.hpp 2.96 KB
EditWeb IDE
×

Replace ComputeProgram.hpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.