Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • OpenGL
  • libGLESv2
  • Program.cpp
Find file
BlameHistoryPermalink
  • Alexis Hetu's avatar
    Fixed a uniform buffer regression · 20c0f656
    Alexis Hetu authored Sep 21, 2016
    The following cl had broken all fragment uniform buffers:
    https://swiftshader-review.googlesource.com/6950
    
    Since the null pointer check was only made on the vertex
    uniform buffer, it was preventing the fragment uniform
    buffer from being set, which was causing a crash when this
    happened.
    
    There was a second issue  with this cl, which was allowing
    'uniformBuffers[-1].get()' to be called, which should not
    have been allowed.
    
    Also, it is safer to call VertexProcessor::setUniformBuffer
    and PixelProcessor::setUniformBuffer unconditionally in order
    to set the null pointers correctly when no buffers are set.
    
    Change-Id: I275b0bca6173ee3df4e0e369926ed0a94500e1ba
    Reviewed-on: https://swiftshader-review.googlesource.com/7216Tested-by: 's avatarAlexis Hétu <sugoi@google.com>
    Reviewed-by: 's avatarNicolas Capens <capn@google.com>
    20c0f656
Program.cpp 78.2 KB
EditWeb IDE
×

Replace Program.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.