Silence clang warning spewed by every .cpp compile

clang: warning: argument unused during compilation: '-s' [-Wunused-command-line-argument] Bug: b/123933266 Change-Id: I809458fa08b9b6b3af7d31c19a90206462d0b0c6 Reviewed-on: https://swiftshader-review.googlesource.com/c/24429 Kokoro-Presubmit: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Tested-by: Ben Clayton <bclayton@google.com>

Silence clang warning spewed by every .cpp compile
09a91e48 · Ben Clayton · 4b9e06d6 · 09a91e48
Commit 09a91e48 authored Feb 05, 2019 by Ben Clayton
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

CMakeLists.txt CMakeLists.txt +4 -1

No files found.
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -248,7 +248,10 @@ else()
    # Use -g3 to have even more debug info
    set_cpp_flag("-g -g3" DEBUG)
    set_cpp_flag("-g -g3" RELWITHDEBINFO)
-    set_cpp_flag("-s" RELEASE)
+    if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        # Treated as an unused argument with clang
+        set_cpp_flag("-s" RELEASE)
+    endif()

    # For distribution it is more important to be slim than super optimized
    set_cpp_flag("-Os" RELEASE)